Skip to content

Clarify the scope of error highlighting in the SARIF report #452

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
mmvpm opened this issue Jul 7, 2022 · 0 comments · Fixed by #454
Closed

Clarify the scope of error highlighting in the SARIF report #452

mmvpm opened this issue Jul 7, 2022 · 0 comments · Fixed by #454
Assignees
@mmvpm
Labels
ctg-enhancement New feature, improvement or change request

Comments

@mmvpm
Copy link
Collaborator

mmvpm commented Jul 7, 2022

Description

The SARIF viewer will highlight the portion of the file specified by physicalLocation.region to display the error.

Now we specify only region.startLine field, so the whole line will be highlighted:
image

But there is no need to highlight an empty space at the beginning of the line.

Expected behavior

An empty space at the beginning of the line is not highlighted:
image
@mmvpm mmvpm added the ctg-enhancement New feature, improvement or change request label Jul 7, 2022
@mmvpm mmvpm self-assigned this Jul 7, 2022
@mmvpm mmvpm moved this to Todo in UTBot Java Jul 7, 2022
@mmvpm mmvpm added this to UTBot Java Jul 7, 2022
@mmvpm mmvpm moved this from Todo to In Progress in UTBot Java Jul 7, 2022
mmvpm added a commit that referenced this issue Jul 7, 2022
@mmvpm
Support startColumn field in the SARIF report (#452)
fefb281
@mmvpm mmvpm mentioned this issue Jul 7, 2022
Merged
7 tasks
mmvpm added a commit that referenced this issue Jul 7, 2022
@mmvpm
Add unit tests (#452)
ed6b541
mmvpm added a commit that referenced this issue Jul 8, 2022
@mmvpm
Fix after review (#452)
9c5a26a
mmvpm added a commit that referenced this issue Jul 8, 2022
@mmvpm
Support startColumn field in the SARIF report (#452)
890361b
mmvpm added a commit that referenced this issue Jul 8, 2022
@mmvpm
Add unit tests (#452)
97e21fc
mmvpm added a commit that referenced this issue Jul 8, 2022
@mmvpm
Fix after review (#452)
f092642
mmvpm added a commit that referenced this issue Jul 8, 2022
@mmvpm
Support startColumn field in the SARIF report (#452)
00b38eb
mmvpm added a commit that referenced this issue Jul 8, 2022
@mmvpm
Add unit tests (#452)
b776266
mmvpm added a commit that referenced this issue Jul 8, 2022
@mmvpm
Fix after review (#452)
5e699f2
mmvpm added a commit that referenced this issue Jul 8, 2022
@mmvpm
Support startColumn field in the SARIF report (#452)
e0afba1
mmvpm added a commit that referenced this issue Jul 8, 2022
@mmvpm
Add unit tests (#452)
ff2d2d1
mmvpm added a commit that referenced this issue Jul 8, 2022
@mmvpm
Fix after review (#452)
1741b70
mmvpm added a commit that referenced this issue Jul 8, 2022
@mmvpm
Add comment (#452)
aeabf14
mmvpm added a commit that referenced this issue Jul 8, 2022
@mmvpm
Rollback coverage usage (#452)
7d02c28
@mmvpm mmvpm closed this as completed in #454 Jul 8, 2022
Repository owner moved this from In Progress to Done in UTBot Java Jul 8, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mmvpm mmvpm

Labels
ctg-enhancement New feature, improvement or change request
Projects
UTBot Java
Archived in project
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Support startColumn field in the SARIF report UnitTestBot/UTBotJava
1 participant
@mmvpm