Skip to content

Support startColumn field in the SARIF report #454

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Jul 8, 2022

Conversation

mmvpm
Copy link
Collaborator

@mmvpm mmvpm commented Jul 7, 2022

Description

Add a new field startColumn to the SARIF report.

An empty space at the beginning of the line is not highlighted:

image

Fixes #452

Type of Change

  • New feature (non-breaking change which adds functionality)

How Has This Been Tested?

Automated Testing

org.utbot.sarif.SarifReportTest

Manual Scenario

  1. Run test generation in any way
  2. Look at the created SARIF report
  3. Make sure it contains physicalLocation.region.startColumn field
  4. Check the highlighted region (examples in the issue Clarify the scope of error highlighting in the SARIF report #452)

Checklist:

  • The change followed the style guidelines of the UTBot project
  • Self-review of the code is passed
  • The change contains enough commentaries, particularly in hard-to-understand areas
  • New documentation is provided or existed one is altered
  • No new warnings
  • Tests that prove my change is effective
  • All tests pass locally with my changes

@mmvpm mmvpm self-assigned this Jul 7, 2022
@mmvpm mmvpm requested a review from nikitavlaev July 8, 2022 07:32
@mmvpm mmvpm force-pushed the ideaseeker/add-start-column-in-sarif branch 2 times, most recently from f092642 to 5e699f2 Compare July 8, 2022 10:40
@mmvpm mmvpm force-pushed the ideaseeker/add-start-column-in-sarif branch from 5e699f2 to 1741b70 Compare July 8, 2022 12:44
@mmvpm mmvpm requested a review from nikitavlaev July 8, 2022 12:46
@mmvpm mmvpm enabled auto-merge (squash) July 8, 2022 12:56
@mmvpm mmvpm requested review from sava-cska and removed request for nikitavlaev July 8, 2022 13:03
@mmvpm mmvpm requested a review from sergeypospelov July 8, 2022 13:25
@mmvpm mmvpm merged commit f47e064 into main Jul 8, 2022
@mmvpm mmvpm deleted the ideaseeker/add-start-column-in-sarif branch July 8, 2022 14:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

Clarify the scope of error highlighting in the SARIF report
4 participants