Skip to content

Don't suggest autogenerated test source roots #2080

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

Vassiliy-Kudryashov
Copy link
Member

Description

Maven generates some roots we shouldn't suggest for tests generation.

Fixes #2068

How to test

Manual tests

Repeat issue's steps even with older IDEA/UnitTestBot versions: actually Maven marks some folders as roots after "Refresh" or touching project model with some additional dependency (Generate JUnit 5 and next time try to generate tests with TestNG: new dependency triggers Maven to mark some directtories as roots).

Self-check list

  • I've set the proper labels for my PR (at least, for category and component).
  • PR title and description are clear and intelligible.
  • I've added enough comments to my code, particularly in hard-to-understand areas.
  • The functionality I've repaired, changed or added is covered with automated tests.
  • Manual tests have been provided optionally.
  • The documentation for the functionality I've been working on is up-to-date.

@Vassiliy-Kudryashov Vassiliy-Kudryashov added comp-ui Improvements of plugin UI appearence and functionality comp-ide Issue is related to IDE support ctg-bug-fix PR is fixing a bug labels Mar 30, 2023
…t-sources-is-suggested-in-ui-dialog-as-test-sources-root
@Vassiliy-Kudryashov Vassiliy-Kudryashov enabled auto-merge (squash) March 30, 2023 15:26
@Vassiliy-Kudryashov Vassiliy-Kudryashov merged commit 8ff1930 into main Mar 31, 2023
@Vassiliy-Kudryashov Vassiliy-Kudryashov deleted the Vassiliy-Kudryashov/2068-targetgenerated-test-sources-is-suggested-in-ui-dialog-as-test-sources-root branch March 31, 2023 06:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
comp-ide Issue is related to IDE support comp-ui Improvements of plugin UI appearence and functionality ctg-bug-fix PR is fixing a bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

target/generated-test-sources is suggested in UI dialog as Test sources root
2 participants