Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Introduce inter-process communication between utbot and utbot-spring-analyzer #2085

Merged
merged 15 commits into from
Apr 10, 2023
Merged

Introduce inter-process communication between utbot and utbot-spring-analyzer #2085

merged 15 commits into from
Apr 10, 2023

Conversation

IlyaMuravjov
Copy link
Collaborator

@IlyaMuravjov IlyaMuravjov commented Mar 31, 2023 •
edited
Loading

Description

Fixes #2039, #2038

  • Add SpringAnalyzerProcess using RD and corresponding run configurations for debugging
  • Make Spring analyzer process use RD logger (logs are sent to engine process, including logs from Spring itself)
  • Extract common code from SpringAnalyzerProcess, EngineProcess, and InstrumentedProcess
  • Add utbot-spring-analyzer shadow jar to utbot-framework resources

Currently, call to utbot-spring-analyzer is disabled with useSpringAnalyzer flag in GenerateTestsModel since utbot-spring-analyzer API is expected to get changed soon, in particular, instead of receiving .properties and .xml file paths it should receive project path and infer these paths on its own. As of now, empty lists are passed.

Markdown docs are to be updated once the implementation is agreed upon.

How to test

Should not be tested standalone, just as a part of Spring support 1st phase.

Self-check list

  • I've set the proper labels for my PR (at least, for category and component).
  • PR title and description are clear and intelligible.
  • I've added enough comments to my code, particularly in hard-to-understand areas.
  • The functionality I've repaired, changed or added is covered with automated tests.
  • Manual tests have been provided optionally.
  • The documentation for the functionality I've been working on is up-to-date.

@IlyaMuravjov IlyaMuravjov added ctg-enhancement New feature, improvement or change request comp-rd Issue is related RD comp-spring Issue is related to Spring projects support labels Mar 31, 2023
@IlyaMuravjov IlyaMuravjov changed the title Add SpringAnalyzerProcess with RD Introduce inter-process communication between utbot and utbot-spring-analyzer Mar 31, 2023
@IlyaMuravjov IlyaMuravjov force-pushed the ilya_m/spring_analyzer_rd branch from 102c652 to 8ffdeb4 Compare April 3, 2023 19:56
@EgorkaKulikov EgorkaKulikov linked an issue Apr 4, 2023 that may be closed by this pull request
Improve classloader used in utbot-spring-analyzer #2038
Closed
Domonion
Domonion requested changes Apr 4, 2023
View reviewed changes
utbot-core/src/main/kotlin/org/utbot/common/StandardStreamUtil.kt Outdated Show resolved Hide resolved
settings.gradle.kts Outdated Show resolved Hide resolved
utbot-framework-api/src/main/kotlin/org/utbot/framework/process/CommonProcessArgs.kt Outdated Show resolved Hide resolved
...strumentation/src/main/kotlin/org/utbot/instrumentation/process/InstrumentedProcessRunner.kt Outdated Show resolved Hide resolved
utbot-intellij/src/main/kotlin/org/utbot/intellij/plugin/models/GenerateTestsModel.kt Show resolved Hide resolved
utbot-intellij/src/main/kotlin/org/utbot/intellij/plugin/process/EngineProcess.kt Show resolved Hide resolved
utbot-rd/build.gradle Outdated Show resolved Hide resolved
utbot-rd/src/main/kotlin/org/utbot/rd/loggers/UtRdLogUtil.kt Outdated Show resolved Hide resolved
utbot-rd/src/main/kotlin/org/utbot/rd/loggers/RDApacheCommonsLogFactory.kt Outdated Show resolved Hide resolved
utbot-framework/src/main/kotlin/org/utbot/framework/process/SpringAnalyzerProcess.kt Outdated Show resolved Hide resolved
@IlyaMuravjov IlyaMuravjov force-pushed the ilya_m/spring_analyzer_rd branch from 723e27d to 0a85c54 Compare April 5, 2023 13:04
@IlyaMuravjov IlyaMuravjov requested a review from Domonion April 5, 2023 15:33
@Domonion Domonion force-pushed the ilya_m/spring_analyzer_rd branch from fde68bf to 1bcd321 Compare April 7, 2023 14:10
Domonion and others added 2 commits April 7, 2023 18:26
@Domonion
[utbot-spring]
7918617 
Refactoring of ClientProtocolBuilder
@IlyaMuravjov
Do more RD processes refactoring
c9abeab
@Domonion Domonion self-requested a review April 7, 2023 16:01
@EgorkaKulikov EgorkaKulikov merged commit 9e2eaae into main Apr 10, 2023
@EgorkaKulikov EgorkaKulikov deleted the ilya_m/spring_analyzer_rd branch April 10, 2023 07:34
This was referenced Apr 10, 2023
Closed
Merged
@alisevych alisevych added this to the Spring Phase 1 milestone Apr 12, 2023
@alisevych alisevych mentioned this pull request Apr 18, 2023
Closed
@EgorkaKulikov EgorkaKulikov mentioned this pull request Apr 18, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Domonion Domonion Domonion approved these changes

@EgorkaKulikov EgorkaKulikov Awaiting requested review from EgorkaKulikov

Assignees
No one assigned
Labels
comp-rd Issue is related RD comp-spring Issue is related to Spring projects support ctg-enhancement New feature, improvement or change request
Projects
None yet
Milestone
Spring Phase 1
4 participants
@IlyaMuravjov @Domonion @EgorkaKulikov @alisevych