Skip to content

Move the Torch wrapper to the separate module #821

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 19 commits into from
Sep 1, 2022

Conversation

amandelpie
Copy link
Collaborator

Description

It reduces the plugin size due to extraction of the additional dependencies to the separate module

Fixes #704

Type of Change

  • Refactoring (typos and non-functional changes)

@amandelpie amandelpie enabled auto-merge (squash) September 1, 2022 09:17
@amandelpie amandelpie requested a review from onewhl September 1, 2022 10:19
Copy link
Member

@onewhl onewhl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Please, take a look at the several comments I left, they are mostly about consistency of naming.

@amandelpie amandelpie merged commit 439a0d8 into main Sep 1, 2022
@amandelpie amandelpie deleted the amandelpie/extract-torch-wrapper branch September 1, 2022 13:31
@amandelpie
Copy link
Collaborator Author

@onewhl oops, I've enabled earlier auto-merge, and it merged without last fixes. I do it quickly and give you on review.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

DJL models and PyTorch wrapper should be in the separate module
2 participants