-
Notifications
You must be signed in to change notification settings - Fork 521
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix: Hidden Archer VFX #739
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jilfranco-unity
added
2-Easy
This PR is trivial and can be reviewed quickly
1-Needs Review
PR needs attention from the assignee and reviewers
labels
Sep 23, 2022
SamuelBellomo
requested review from
fernando-cortez and
pdeschain
and removed request for
SamuelBellomo
September 23, 2022 18:40
SamuelBellomo
added
the
0-URGENT
Blocker for a release and needs to be merged ASAP
label
Sep 26, 2022
fernando-cortez
requested changes
Sep 26, 2022
fernando-cortez
added
2-Reviewed with Comments
PR requires owner's attention
and removed
1-Needs Review
PR needs attention from the assignee and reviewers
labels
Sep 26, 2022
# Conflicts: # Assets/VFX/Prefabs/Archer/fx_ArrowGraphics.prefab # Assets/VFX/Prefabs/Archer/fx_ChargedArrow1Graphics.prefab # Assets/VFX/Prefabs/Archer/fx_ChargedArrow2Graphics.prefab # Assets/VFX/Prefabs/Archer/fx_ChargedArrow3Graphics.prefab
fernando-cortez
approved these changes
Sep 27, 2022
fernando-cortez
added
2-One More Review
One review in, one to go
and removed
2-Reviewed with Comments
PR requires owner's attention
labels
Sep 27, 2022
LPLafontaineB
approved these changes
Sep 29, 2022
LPLafontaineB
added
3-Good to Merge
and removed
2-One More Review
One review in, one to go
labels
Sep 29, 2022
SamuelBellomo
added a commit
that referenced
this pull request
Oct 13, 2022
* develop: (60 commits) fix: removing FindObjectOfType for a serialized reference (#754) fix: can click through loading screen [MTT-4753] (#760) Update CHANGELOG.md (#765) feat: Architecture.md update (MTT-2637) (#763) Update README.md (#759) Updating utilities package for release (#764) Version bumps (#761) Updating broken PR links (shouldn't be linked to jira) and changelog fixes (#758) adding components refs to index (#757) Adding link to feedback form at the top (#756) chore: adding details to changelog (#746) Updating readme with Typeform for feedback (#755) made arrow trails smaller (#750) Fixed up some layer settings on some archer VFX so that they show up properly! (#739) fix: lobby UI unblocking before it should [MTT-4579] (#748) feat: PubSub improvement: ISubscriber unsub [MTT-2765] (#612) Fix: Reduction of SSAO Cost (Especially on Mac) [MTT-4558] (#753) fix: Moving utp to component instead of child GameObject (#752) Adding TOC and index to readme [MTT-4617] (#736) Feat: Char Portrait Mouse Hover Feedback [MTT-4754] (#751) ... # Conflicts: # Assets/Prefabs/NetworkingManager.prefab
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
0-URGENT
Blocker for a release and needs to be merged ASAP
2-Easy
This PR is trivial and can be reviewed quickly
3-Good to Merge
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
A quick fix on the layers for some archer VFX so that they're not hidden completely on certain quality settings!
Issue Number(s)
N/A
Contribution checklist