Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adding link to feedback form at the top #756

Merged
merged 3 commits into from
Oct 4, 2022
Merged

Adding link to feedback form at the top #756

merged 3 commits into from
Oct 4, 2022

Conversation

SamuelBellomo
Copy link
Contributor

Description

Issue Number(s)

Contribution checklist

  • Tests have been added for boss room and/or utilities pack
  • Release notes have been added to the project changelog file and/or package changelog file
  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • JIRA ticket ID is in the PR title or at least one commit message
  • Include the ticket ID number within the body message of the PR to create a hyperlink

@SamuelBellomo SamuelBellomo added 0-URGENT Blocker for a release and needs to be merged ASAP 2-Easy This PR is trivial and can be reviewed quickly 1-Needs Review PR needs attention from the assignee and reviewers labels Oct 4, 2022
@SamuelBellomo SamuelBellomo marked this pull request as ready for review October 4, 2022 14:52
chrispope
chrispope reviewed Oct 4, 2022
View reviewed changes
Copy link
Collaborator

@chrispope chrispope left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You could remove it from the TOC if we are moving it to the top.

chrispope
chrispope reviewed Oct 4, 2022
View reviewed changes
Copy link
Collaborator

@chrispope chrispope left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You could remove it from the TOC if we are moving it to the top.

@SamuelBellomo
Copy link
Contributor Author

You could remove it from the TOC if we are moving it to the top.

@chrispope I preferred to keep there as well, just to be complete. This way with auto-TOC generation, we won't have to remove it all the time.

@chrispope
Copy link
Collaborator

You could remove it from the TOC if we are moving it to the top.

@chrispope I preferred to keep there as well, just to be complete. This way with auto-TOC generation, we won't have to remove it all the time.

Makes sense.

@chrispope chrispope self-requested a review October 4, 2022 15:04
@fernando-cortez fernando-cortez added 3-Good to Merge and removed 1-Needs Review PR needs attention from the assignee and reviewers labels Oct 4, 2022
@SamuelBellomo SamuelBellomo enabled auto-merge (squash) October 4, 2022 17:11
@SamuelBellomo SamuelBellomo disabled auto-merge October 4, 2022 17:24
@SamuelBellomo SamuelBellomo merged commit cbc2cbd into develop Oct 4, 2022
@SamuelBellomo SamuelBellomo deleted the Add-link-to-feedback-form branch October 4, 2022 17:24
SamuelBellomo added a commit that referenced this pull request Oct 13, 2022
@SamuelBellomo
Merge branch 'develop' into sam/feat/bump-NGO-to-1.1
c13ba78 
* develop: (60 commits)
  fix: removing FindObjectOfType for a serialized reference (#754)
  fix: can click through loading screen [MTT-4753] (#760)
  Update CHANGELOG.md (#765)
  feat: Architecture.md update (MTT-2637) (#763)
  Update README.md (#759)
  Updating utilities package for release (#764)
  Version bumps (#761)
  Updating broken PR links (shouldn't be linked to jira) and changelog fixes (#758)
  adding components refs to index (#757)
  Adding link to feedback form at the top (#756)
  chore: adding details to changelog (#746)
  Updating readme with Typeform for feedback (#755)
  made arrow trails smaller (#750)
  Fixed up some layer settings on some archer VFX so that they show up properly! (#739)
  fix: lobby UI unblocking before it should [MTT-4579] (#748)
  feat: PubSub improvement: ISubscriber unsub [MTT-2765] (#612)
  Fix: Reduction of SSAO Cost (Especially on Mac) [MTT-4558] (#753)
  fix: Moving utp to component instead of child GameObject (#752)
  Adding TOC and index to readme [MTT-4617] (#736)
  Feat: Char Portrait Mouse Hover Feedback [MTT-4754] (#751)
  ...

# Conflicts:
#	Assets/Prefabs/NetworkingManager.prefab
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fernando-cortez fernando-cortez fernando-cortez approved these changes

@chrispope chrispope chrispope approved these changes

@MorwennaG MorwennaG Awaiting requested review from MorwennaG

Assignees
No one assigned
Labels
0-URGENT Blocker for a release and needs to be merged ASAP 2-Easy This PR is trivial and can be reviewed quickly 3-Good to Merge
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@SamuelBellomo @chrispope @fernando-cortez @netcode-ci-service