Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: bump unity 2021.3.10f1 #740

Merged
merged 5 commits into from
Sep 27, 2022
Merged

chore: bump unity 2021.3.10f1 #740

merged 5 commits into from
Sep 27, 2022

Conversation

SamuelBellomo
Copy link
Contributor

@SamuelBellomo SamuelBellomo commented Sep 23, 2022 •
edited
Loading

Description

Editor bump and associated package auto-bumps.
WARNING: this should be merged only once lobby fixes are in.

Issue Number(s)

None

Contribution checklist

  • n/a Tests have been added for boss room and/or utilities pack
  • Release notes have been added to the project changelog file and/or package changelog file
  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • n/a JIRA ticket ID is in the PR title or at least one commit message
  • n/a Include the ticket ID number within the body message of the PR to create a hyperlink

@SamuelBellomo SamuelBellomo marked this pull request as ready for review September 23, 2022 19:18
@SamuelBellomo SamuelBellomo added 0-URGENT Blocker for a release and needs to be merged ASAP 2-Easy This PR is trivial and can be reviewed quickly 1-Needs Review PR needs attention from the assignee and reviewers DO NOT MERGE Do not merge this PR! labels Sep 23, 2022
@SamuelBellomo
Copy link
Contributor Author

There's a new error that pops up when stopping the game with URP with this bump. This seems to be a known issue.

@SamuelBellomo
Merge branch 'develop' into sam/chore/bump-unity-2021.3.10f1
bbca4ef 
* develop:
  feat: upgrade lobby [MTT-3962][MTT-4105][MTT-4052] (#737)
  fix: shield charge trigger reset & reuse cooldown populated [MTT-4100] (#742)

# Conflicts:
#	CHANGELOG.md
#	Packages/manifest.json
#	Packages/packages-lock.json
@SamuelBellomo
settings that were updated with the version bump
7f2e6ed
@SamuelBellomo SamuelBellomo removed 1-Needs Review PR needs attention from the assignee and reviewers DO NOT MERGE Do not merge this PR! labels Sep 26, 2022
@SamuelBellomo SamuelBellomo enabled auto-merge (squash) September 26, 2022 22:03
@fernando-cortez fernando-cortez added the 2-One More Review One review in, one to go label Sep 27, 2022
@SamuelBellomo SamuelBellomo merged commit fdd428a into develop Sep 27, 2022
@SamuelBellomo SamuelBellomo deleted the sam/chore/bump-unity-2021.3.10f1 branch September 27, 2022 14:47
@LPLafontaineB LPLafontaineB added 3-Good to Merge and removed 2-One More Review One review in, one to go labels Sep 27, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@LPLafontaineB LPLafontaineB LPLafontaineB approved these changes

@fernando-cortez fernando-cortez fernando-cortez approved these changes

@pdeschain pdeschain Awaiting requested review from pdeschain

@jilfranco-unity jilfranco-unity Awaiting requested review from jilfranco-unity

Assignees
No one assigned
Labels
0-URGENT Blocker for a release and needs to be merged ASAP 2-Easy This PR is trivial and can be reviewed quickly 3-Good to Merge
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@SamuelBellomo @fernando-cortez @LPLafontaineB