feat: ClientPlayerAvatarNetworkAnimator added to handle client synchronizations [MTT-3152] #886
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR rectifies two things:
ServerAnimationHandler
to wait untilNetworkAnimator
's Animator field had been assigned. That is no longer an issue with Netcode for GameObjects, and thisNetworkBehaviour
was also incorrectly playing an animation on newly joining clients on OnNetworkSpawn(). Instead, theNetworkAnimator
's synchronize step should have handled applying its sync data to clients. However, players need to instantiate a model before the synchronize data is applied, and so:ClientPlayerAvatarNetworkAnimator
has been created to handle: instantiating the player model based on a networked GUID, rebinding this rig to the player's Animator, and applying synchronize data to said Animator.To validate this fix:
Issue Number(s)
MTT-3152
Contribution checklist