Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: NetworkAnimator generating AnimationCurve warnings #2416

Merged

Conversation

NoelStephensUnity
Copy link
Collaborator

@NoelStephensUnity NoelStephensUnity commented Feb 17, 2023

This PR resolves an issue where NetworkAnimator was building a delta check list for any parameter not controlled by AnimationCurve during initialization which could change during runtime. This update generates a delta check list for all parameters and culls out any parameter controlled by an AnimationCurve when checking for parameter deltas. This includes an additional minor fix to an issue that could occur where if the associated Animator (assigned to NetworkAnimator) was disabled in the editor it would spam exceptions to the console log.

MTT-5491
Related Github Issue:
#2391

Changelog

  • Fixed: issue where runtime association of Animator properties to AnimationCurves would cause NetworkAnimator to attempt to update those changes.
  • Fixed: issue where NetworkAnimator would not check if its associated Animator was valid during serialization and would spam exceptions in the editor console.indicate where the entry should go.

Testing and Documentation

  • No tests have been added or modified.

Don't try to access m_Animator if it is not assigned.
Don't try to update animation curves.
Now generate a tracking list for all parameters and cull out those controlled by AnimationCurves when checking for deltas.

Added initial changelog entries.
Adding PR number to changelog entries.
@NoelStephensUnity NoelStephensUnity marked this pull request as ready for review February 17, 2023 22:34
@NoelStephensUnity NoelStephensUnity requested a review from a team as a code owner February 17, 2023 22:34
@NoelStephensUnity NoelStephensUnity enabled auto-merge (squash) March 2, 2023 02:04
@NoelStephensUnity NoelStephensUnity merged commit 8b8825b into develop Mar 2, 2023
@NoelStephensUnity NoelStephensUnity deleted the fix/networkanimator-animationcurve-warnings branch March 2, 2023 02:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants