Skip to content

Commit

Permalink
Removed the default for width and height of the executable training. (#…
Browse files Browse the repository at this point in the history
…3867)

* Removed the default for width and height of the executable training. This is to help relove #3835 since setting the screen resolution on Linux 2019.3 can cause issues.

* Editing the changelog

* Making fields in EngineConfig optional
  • Loading branch information
vincentpierre authored Apr 27, 2020
1 parent cbd01e0 commit c69ad6b
Show file tree
Hide file tree
Showing 3 changed files with 9 additions and 8 deletions.
1 change: 1 addition & 0 deletions com.unity.ml-agents/CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -93,6 +93,7 @@ you will need to change the signature of its `Write()` method. (#3834)
- The maximum compatible version of tensorflow was changed to allow tensorflow 2.1 and 2.2. This
will allow use with python 3.8 using tensorflow 2.2.0rc3.
- `UnityRLCapabilities` was added to help inform users when RL features are mismatched between C# and Python packages. (#3831)
- `mlagents-learn` will no longer set the width and height of the executable window to 84x84 when no width nor height arguments are given

### Bug Fixes

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -9,12 +9,12 @@


class EngineConfig(NamedTuple):
width: int
height: int
quality_level: int
time_scale: float
target_frame_rate: int
capture_frame_rate: int
width: Optional[int]
height: Optional[int]
quality_level: Optional[int]
time_scale: Optional[float]
target_frame_rate: Optional[int]
capture_frame_rate: Optional[int]

@staticmethod
def default_config():
Expand Down
4 changes: 2 additions & 2 deletions ml-agents/mlagents/trainers/learn.py
Original file line number Diff line number Diff line change
Expand Up @@ -201,14 +201,14 @@ def _create_parser():
eng_conf = argparser.add_argument_group(title="Engine Configuration")
eng_conf.add_argument(
"--width",
default=84,
default=None,
type=int,
help="The width of the executable window of the environment(s) in pixels "
"(ignored for editor training).",
)
eng_conf.add_argument(
"--height",
default=84,
default=None,
type=int,
help="The height of the executable window of the environment(s) in pixels "
"(ignored for editor training)",
Expand Down

0 comments on commit c69ad6b

Please sign in to comment.