Removed the default for width and height of the executable training. #3867
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…This is to help relove #3835 since setting the screen resolution on Linux 2019.3 can cause issues.
|
Should the changelog be updated to call this out? |
|
Can you update the types on EngineConfig to make them Optional[int]'s? |
chriselion
approved these changes
Apr 27, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is to help resolve #3835 since setting the screen resolution on Linux 2019.3 can cause issues.
Proposed change(s)
learn.py no longer sets the width and height of the executable window to 84x84.
We do not have a limitation page but we should explain somewhere that linux executable on 2019.3 cannot set the width and height of the executable window.
Useful links (Github issues, JIRA tickets, ML-Agents forum threads etc.)
Types of change(s)
Checklist
Other comments