-
Notifications
You must be signed in to change notification settings - Fork 4.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Develop modify stepping logic #3448
Conversation
- Created a new Academy Event called AgentIncrementStep to be called before SetStatus - Implemented the AgentSteping logic
…it the tests but I think they are now closer to what we want
what does the step count look like for an episode? It looks like if
Is my understanding correct? |
Yes, this is what I am aiming at |
Co-Authored-By: Chris Goy <goyenator@gmail.com>
Co-Authored-By: Chris Goy <goyenator@gmail.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
seems to make sense. Should there be a test for this?
Co-Authored-By: Chris Elion <chris.elion@unity3d.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, just add something in the changelog.
Proposed change(s)
Making changes to the step counting in both the Academy and the Agent.
The Academy will first set status, then tick its step count, then tick all agents step counts.
Collect observations and Act happen as usual.
At the end of the loop, the Agent resets if max step was reached.
Useful links (Github issues, JIRA tickets, ML-Agents forum threads etc.)
Is continuation of #3432
Jira is MLA-619
Types of change(s)
Checklist
Other comments