Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix the torch device option in argparser #5467

Merged
merged 2 commits into from
Jul 23, 2021
Merged

Fix the torch device option in argparser #5467

merged 2 commits into from
Jul 23, 2021

Conversation

dongruoping
Copy link
Contributor

Proposed change(s)

I fixed the attribute name part in #5433 but it broke the part when assigning the value from argparser to TorchSettings.

Useful links (Github issues, JIRA tickets, ML-Agents forum threads etc.)

Types of change(s)

  • Bug fix
  • New feature
  • Code refactor
  • Breaking change
  • Documentation update
  • Other (please describe)

Checklist

  • Added tests that prove my fix is effective or that my feature works
  • Updated the changelog (if applicable)
  • Updated the documentation (if applicable)
  • Updated the migration guide (if applicable)

Other comments

@dongruoping dongruoping requested a review from ervteng July 22, 2021 21:24
ervteng
ervteng approved these changes Jul 22, 2021
View reviewed changes
Copy link
Contributor

@ervteng ervteng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we need to add this one to the changelog.md

@dongruoping dongruoping merged commit 5ffc783 into main Jul 23, 2021
@delete-merged-branch delete-merged-branch bot deleted the develop-fix-device branch July 23, 2021 00:50
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jul 23, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@ervteng ervteng ervteng approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@dongruoping @ervteng