Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix the torch device option in argparser #5467

Merged
merged 2 commits into from
Jul 23, 2021
Merged

Fix the torch device option in argparser #5467

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
7be0279
fix device option
dongruoping Jul 22, 2021
2382183
changelog
dongruoping Jul 22, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions com.unity.ml-agents/CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,6 +18,7 @@ and this project adheres to
#### ml-agents / ml-agents-envs / gym-unity (Python)
- Fixed a bug in multi-agent cooperative training where agents might not receive all of the states of
terminated teammates. (#5441)
- Fixed wrong attribute name in argparser for torch device option (#5433)(#5467)

## [2.1.0-exp.1] - 2021-06-09
### Minor Changes
Expand Down
2 changes: 1 addition & 1 deletion ml-agents/mlagents/trainers/cli_utils.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -257,7 +257,7 @@ def _create_parser() -> argparse.ArgumentParser:
torch_conf.add_argument(
"--torch-device",
default=None,
dest="torch_device",
dest="device",
action=DetectDefault,
help='Settings for the default torch.device used in training, for example, "cpu", "cuda", or "cuda:0"',
)
Expand Down
2 changes: 1 addition & 1 deletion ml-agents/mlagents/trainers/settings.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -797,7 +797,7 @@ class EngineSettings:

@attr.s(auto_attribs=True)
class TorchSettings:
device: Optional[str] = parser.get_default("torch_device")
device: Optional[str] = parser.get_default("device")


@attr.s(auto_attribs=True)
Expand Down