Method to return stacked observations #5547
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
miguelalonsojr
requested changes
Oct 18, 2021
com.unity.ml-agents/CHANGELOG.md
Outdated
| @@ -13,6 +13,7 @@ and this project adheres to | |||
| ### Minor Changes | |||
| #### com.unity.ml-agents / com.unity.ml-agents.extensions (C#) | |||
| - Added the capacity to initialize behaviors from any checkpoint and not just the latest one (#5525) | |||
| - Agent can now view the StackedVectorObservations (#5523) | |||
There was a problem hiding this comment.
can you change this to read:
"Added the ability to get a read-only view of the stacked observations (#5523)
| @@ -279,5 +286,20 @@ public BuiltInSensorType GetBuiltInSensorType() | |||
| IBuiltInSensor wrappedBuiltInSensor = m_WrappedSensor as IBuiltInSensor; | |||
| return wrappedBuiltInSensor?.GetBuiltInSensorType() ?? BuiltInSensorType.Unknown; | |||
| } | |||
|
|
|||
| /// <summary> | |||
| /// Returns a read-only view of the observations that added. | |||
There was a problem hiding this comment.
Can you update this to read:
"Returns the stacked observations as a read-only collection.
| /// <summary> | ||
| /// Returns a read-only view of the observations that added. | ||
| /// </summary> | ||
| /// <returns>A read-only view of the observations list.</returns> |
There was a problem hiding this comment.
Can you update this to read:
"The stacked observations as a read-only collection."
cmard
force-pushed
the
stacked-observations
branch
from
64177d4 to
80e4fe8
Compare
Comment on lines
39
to
43
| //[ | ||
| //[1,2] | ||
| //[3,4] | ||
| //[5,6] | ||
| //] |
There was a problem hiding this comment.
are these comments needed?
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed change(s)
Agent can now access the stacked vector observations by calling
GetStackedObservations()#5523Useful links (Github issues, JIRA tickets, ML-Agents forum threads etc.)
Types of change(s)
Checklist
Other comments