-
Notifications
You must be signed in to change notification settings - Fork 79
[USDU-230][USDU-232][USDU-275] Add testcases regarding texture mapping #328
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
package/com.unity.formats.usd/Runtime/Scripts/IO/Scene/ImportHelpers.cs
Outdated
Show resolved
Hide resolved
vickycl
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we reduce the sizes or remove some of the textures please? A few 100kb can add up quite quickly over the amount of times they're downloaded, and they could be really tiny and still function the same in these tests.
package/com.unity.formats.usd/Runtime/Scripts/IO/Scene/ImportHelpers.cs
Outdated
Show resolved
Hide resolved
vickycl
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Very nice! Just a few small requests:
-
Textures could still be smaller :P a single texture of a single colour shouldn't need to be more than 64x64pix, maybe even less.
-
I don't see a test in here for USDU-275 (which I don't think has been fixed, so would fail anyway), am I missing something?
package/com.unity.formats.usd/Tests/Common/CustomAsserts/ImportAssert.cs
Outdated
Show resolved
Hide resolved
…script and reducing the sizes of test textures
570ffe7 to
82509d9
Compare
vickycl
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good! Thank you for the iterations :)
|
Thank you for the reviews @vickycl and @unity-chris ! |
Purpose of this PR
Ticket/Jira #:
[USDU-230][USDU-232][USDU-275]
Testing
Functional Testing status:
Adds Testcases:
Overall Product Risks
ImportHelper.cs:
Complexity:
1
Halo Effect:
1
Additional information
Note to reviewers:
Reminder:
Requires: #327 to be pushed in first