[USDU-274] Adds new test cases for ImportHelper functions #327
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lee-aandrew
force-pushed
the
add-testcase-ImportHelper
branch
from
de43c01 to
1b5bd43
Compare
vickycl
suggested changes
Jan 4, 2023
Contributor
vickycl
left a comment
vickycl
left a comment
There was a problem hiding this comment.
Added some suggestions, overall nice tests and great work!
package/com.unity.formats.usd/Tests/Editor/ImportHelpersTests.cs
Outdated
Show resolved
Hide resolved
| var usdAsObjects = AssetDatabase.LoadAllAssetsAtPath(assetPath); | ||
|
|
||
| // ExpectedGameObjectCount: The Root GameObject | ||
| // ExpectedPrimSourceCount: 0 TODO: Shouldnt there be a prim source object for the root object? |
Contributor
Author
There was a problem hiding this comment.
Its more of a question than a TODO - im not sure why there isnt a prim source object for the root object when imported as a Timeline Clip
Contributor
There was a problem hiding this comment.
Possibly a question for @mirceaispas , I think there is no prim source because the root isn't considered an actual prim in USD terms?
package/com.unity.formats.usd/Tests/Editor/ImportHelpersTests.cs
Outdated
Show resolved
Hide resolved
package/com.unity.formats.usd/Tests/Editor/ImportHelpersTests.cs
Outdated
Show resolved
Hide resolved
package/com.unity.formats.usd/Tests/Editor/ImportHelpersTests.cs
Outdated
Show resolved
Hide resolved
unity-chris
reviewed
Jan 6, 2023
Contributor
Author
|
Thank you for the reviews @vickycl @unity-chris ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose of this PR
Ticket/Jira #: https://jira.unity3d.com/browse/USDU-274
Adds new test cases for functions within ImportHelper.cs script to increase coverage and to act as an onboarding task for @lee-aandrew
Testing
Functional Testing status:
N/A
Performance Testing status:
N/A
Overall Product Risks
N/A
Complexity:
1
Halo Effect:
1
Additional information
Note to reviewers:
Not sure if this is a bug or a intended way of doing things, but USD.Scene.Write, when given an object of type Parent Class, it will not write anything
For example:
SampleBase testArray[] { SphereSample sphere1, SphereSample sphere2 } // SampleBase is the root parent of SphereSample
Scene.Write("/root/sphere" testArray[0])
The Write in this case would not write anything to the scene