Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add breaking api changes from ros2_control to hardware_interface #189

Merged
merged 2 commits into from
Oct 4, 2021
Merged

Add breaking api changes from ros2_control to hardware_interface #189

merged 2 commits into from
Oct 4, 2021

Conversation

livanov93
Copy link
Contributor

@livanov93 livanov93 self-assigned this Sep 29, 2021
destogl
destogl approved these changes Sep 30, 2021
View reviewed changes
Copy link
Contributor

@destogl destogl left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Three small optimization proposals. Otherwise, all good! Thanks!

ur_robot_driver/include/ur_robot_driver/hardware_interface.hpp Outdated Show resolved Hide resolved
ur_robot_driver/include/ur_robot_driver/hardware_interface.hpp Outdated Show resolved Hide resolved
ur_robot_driver/include/ur_robot_driver/hardware_interface.hpp Outdated Show resolved Hide resolved
@livanov93 livanov93 merged commit a4d6784 into UniversalRobots:main Oct 4, 2021
@livanov93 livanov93 deleted the livanov/hardware_to_lifecycle_interface_transition branch October 4, 2021 11:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@destogl destogl destogl approved these changes

Assignees

@livanov93 livanov93

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@livanov93 @destogl