Use upstream repo, not fmauch/universal_robot

[davetcoleman]

Currently the README build instructions ask us to clone fmauch/universal_robot, which is a branch in a fork of a fork. I'd like to submit a fix to this repo but it would be best if I could submit that fix to the upstream https://github.com/ros-industrial/universal_robot.

Are there efforts to get these changes merged back into the original ROS-Industrial repo? @gavanderhoorn ?

Side note, the fix I'd like to make:

ros.moveit_ros_planning.kinematics_plugin_loader: Kinematics solver doesn't support #attempts anymore, but only a timeout.
Please remove the parameter '/rviz_davetop_30024_1507649081703232519/manipulator/kinematics_solver_attempts' from your configuration.
ros.moveit_core.kinematics_base: IK plugin for group 'manipulator' relies on deprecated API. Please implement initialize(RobotModel, ...).

[gavanderhoorn]

Are there efforts to get these changes merged back into the original ROS-Industrial repo?

Yes.

[fmauch]

Now that we have an open issue clearly covering this:

There is a PR going on changing a lot in generating the robot descriptions.

We plan to merge this in first, so the calibration stuff will be generated on top of that. The current PR of my fork is therefore currently on hold.

[fmessmer]

@fmauch @gavanderhoorn
as ros-industrial/universal_robot#371 has been merged recently, what's the plan now for officially using ros-industrial/universal_robot (i.e. ur_description) with this driver?

I guess this is also related to ros-industrial/universal_robot#448

The README here still mentions fmauch/calibration_devel
So there still needs to be a PR from fmauch/calibration_devel to ros-industrial/melodic-devel-staging (i.e. https://github.com/ros-industrial/universal_robot/compare/melodic-devel-staging...fmauch:calibration_devel?expand=1), right?

Or has this been covered in ros-industrial/universal_robot#495?
Then this repo's README needs to be adjusted!

[gavanderhoorn]

I had hoped the -staging suffix on the branch name would have been clear enough, but: as long as the staging branch has not been merged into melodic-devel, nothing changes.

I can assure you once things have been merged and released we will be vocal about it. Then the readmes can be updated.

[boilerbots]

I am interested in seeing this getting cleaned up. Anyway we can make progress on this?

I am also hoping we can get a proper package built and deployed for Melodic.

[fmauch]

This seems like is has been resolved long ago...