fix: make segment ids deserialize as ints instead of strings (#174)

Unleash · Nov 17, 2023 · 3378109 · 3378109
1 parent cccf3ef
commit 3378109
Show file tree

Hide file tree

Showing 4 changed files with 11 additions and 11 deletions.
diff --git a/src/Unleash/Internal/ActivationStrategy.cs b/src/Unleash/Internal/ActivationStrategy.cs
@@ -8,15 +8,15 @@ public class ActivationStrategy
         public string Name { get; }
         public Dictionary<string, string> Parameters { get; }
         public List<Constraint> Constraints { get; }
-        public List<string> Segments { get; }
+        public List<int> Segments { get; }
         public List<VariantDefinition> Variants { get; }
 
-        public ActivationStrategy(string name, Dictionary<string, string> parameters, List<Constraint> constraints = null, List<string> segments = null, List<VariantDefinition> variants = null)
+        public ActivationStrategy(string name, Dictionary<string, string> parameters, List<Constraint> constraints = null, List<int> segments = null, List<VariantDefinition> variants = null)
         {
             Name = name;
             Parameters = parameters ?? new Dictionary<string, string>();
             Constraints = constraints ?? new List<Constraint>();
-            Segments = segments ?? new List<string>();
+            Segments = segments ?? new List<int>();
             Variants = variants ?? new List<VariantDefinition>();
         }
     }

diff --git a/src/Unleash/Internal/Segment.cs b/src/Unleash/Internal/Segment.cs
@@ -6,9 +6,9 @@ namespace Unleash.Internal
 {
     public class Segment
     {
-        public string Id { get; }
+        public int Id { get; }
         public List<Constraint> Constraints { get; }
-        public Segment(string id, List<Constraint> constraints = null)
+        public Segment(int id, List<Constraint> constraints = null)
         {
             Id = id;
             Constraints = constraints ?? new List<Constraint>();

diff --git a/src/Unleash/Internal/ToggleCollection.cs b/src/Unleash/Internal/ToggleCollection.cs
@@ -16,15 +16,15 @@ public class ToggleCollection
 
         private readonly Dictionary<string, FeatureToggle> togglesCache;
 
-        private readonly Dictionary<string, Segment> segmentsCache;
+        private readonly Dictionary<int, Segment> segmentsCache;
 
         public ToggleCollection(ICollection<FeatureToggle> features = null, ICollection<Segment> segments = null)
         {
             Features = features ?? new List<FeatureToggle>(0);
             Segments = segments ?? new List<Segment>(0);
 
             togglesCache = new Dictionary<string, FeatureToggle>(Features.Count);
-            segmentsCache = new Dictionary<string, Segment>(Segments.Count);
+            segmentsCache = new Dictionary<int, Segment>(Segments.Count);
 
             foreach (var featureToggle in Features) {
                 togglesCache.Add(featureToggle.Name, featureToggle);
@@ -47,7 +47,7 @@ public FeatureToggle GetToggleByName(string name)
                 : null;
         }
 
-        public Segment GetSegmentById(string id)
+        public Segment GetSegmentById(int id)
         {
             return segmentsCache.TryGetValue(id, out var value)
                 ? value

diff --git a/tests/Unleash.Tests/Strategy/Segments_Tests.cs b/tests/Unleash.Tests/Strategy/Segments_Tests.cs
@@ -24,7 +24,7 @@ public void Two_Constraints_With_Item_Id_Equals_1_And_Context_Item_Id_Equals_1_S
         {
             // Arrange
             var appname = "masstest";
-            var segmentIds = new List<string>() { "1", "2" };
+            var segmentIds = new List<int>() { 1, 2 };
             var toggles = new List<FeatureToggle>()
             {
                 new FeatureToggle("item", "release", true, false, new List<ActivationStrategy>() { new ActivationStrategy("default", new Dictionary<string, string>(), null, segmentIds) })
@@ -49,7 +49,7 @@ public void Two_Constraints_One_Correct_In_Segment_One_Wrong_In_Strategy_Should_
         {
             // Arrange
             var appname = "masstest";
-            var segmentIds = new List<string>() { "1" };
+            var segmentIds = new List<int>() { 1 };
             var toggles = new List<FeatureToggle>()
             {
                 new FeatureToggle("item", "release", true, false, new List<ActivationStrategy>() { new ActivationStrategy("default", new Dictionary<string, string>(), new List<Constraint>() { new Constraint("item-id", Operator.NUM_EQ, false, false, "15") }, segmentIds) })
@@ -74,7 +74,7 @@ public void Two_Constraints_One_In_Segment_One_In_Strategy_Both_Correct_Should_E
         {
             // Arrange
             var appname = "masstest";
-            var segmentIds = new List<string>() { "1" };
+            var segmentIds = new List<int>() { 1 };
             var toggles = new List<FeatureToggle>()
             {
                 new FeatureToggle("item", "release", true, false, new List<ActivationStrategy>() { new ActivationStrategy("default", new Dictionary<string, string>(), new List<Constraint>() { new Constraint("item-id", Operator.NUM_EQ, false, false, "1") }, segmentIds) })