Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: make segment ids deserialize as ints instead of strings #174

Merged
merged 1 commit into from
Nov 17, 2023

Conversation

daveleek
Copy link
Collaborator

Description

Segment ids were being sent as numbers but deserialized into strings, which can cause deserialization errors. This fix changes the local type of segment ids to be ints

Fixes #173

Type of change

  • Bug fix (non-breaking change which fixes an issue)

How Has This Been Tested?

  • Running all unit tests

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

@daveleek daveleek requested a review from sighphyre November 14, 2023 12:04
Copy link
Member

@sighphyre sighphyre left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

G

@daveleek daveleek merged commit 3378109 into main Nov 17, 2023
@daveleek daveleek deleted the fix/segment-ids-as-ints branch November 17, 2023 10:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

System.Text.Json.JsonException when dezerializing json to Unleash.Internal.ToggleCollection
2 participants