Feat: dependent features #55
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Tymek
commented
Sep 26, 2023
| if (strategyVariant) { | ||
| return strategyVariant; | ||
| } | ||
|
|
||
| if (feature?.variants) { | ||
| if ( | ||
| (feature?.strategies.length === 0 || hasEnabledStrategy) && |
There was a problem hiding this comment.
Fix for another corner case in client spec
Tymek
commented
Sep 26, 2023
| @@ -55,7 +55,7 @@ | |||
| "commander": "11.0.0", | |||
| "murmurhash3js": "3.0.1", | |||
| "semver": "7.5.4", | |||
| "unleash-client": "4.1.0", | |||
| "unleash-client": "4.2.0-beta.0", | |||
There was a problem hiding this comment.
types-only, so beta here is OK
Tymek
commented
Sep 26, 2023
lib/src/utils.d.ts
Outdated
There was a problem hiding this comment.
commited before by mistake, not source file
kwasniew
approved these changes
Sep 26, 2023
renovate bot
referenced
this pull request
in simonknittel/sinister-incorporated
Dec 22, 2023
[](https://renovatebot.com) This PR contains the following updates: | Package | Change | Age | Adoption | Passing | Confidence | |---|---|---|---|---|---| | [@unleash/nextjs](https://togithub.com/Unleash/unleash-client-nextjs) | [`1.2.0` -> `1.3.0`](https://renovatebot.com/diffs/npm/@unleash%2fnextjs/1.2.0/1.3.0) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | --- ### Release Notes <details> <summary>Unleash/unleash-client-nextjs (@​unleash/nextjs)</summary> ### [`v1.3.0`](https://togithub.com/Unleash/unleash-client-nextjs/releases/tag/v1.3.0) [Compare Source](https://togithub.com/Unleash/unleash-client-nextjs/compare/v1.2.0...v1.3.0) #### What's Changed - Feat: dependent features by [@​Tymek](https://togithub.com/Tymek) in [https://github.com/Unleash/unleash-client-nextjs/pull/55](https://togithub.com/Unleash/unleash-client-nextjs/pull/55) - Update dependencies by [@​Tymek](https://togithub.com/Tymek) in [https://github.com/Unleash/unleash-client-nextjs/pull/56](https://togithub.com/Unleash/unleash-client-nextjs/pull/56) **Fix for server-side SDK: Hashing for variants was improved.** Previously when using *Variants* in combination with *Gradual Rollout*, distribution of *Variants* could be significantly skewed. This version complies with current [Unleash Client Specification](https://togithub.com/Unleash/client-specification). If you're using *Frontend API* and *Gradual Rollout* strategies and *Variants* at the same time it's recommended to stay up to date with [Unleash](https://togithub.com/Unleash/unleash/releases) updates to benefit from this improvement. **Full Changelog**: Unleash/unleash-client-nextjs@v1.2.0...v1.3.0 </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Enabled. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR has been generated by [Mend Renovate](https://www.mend.io/free-developer-tools/renovate/). View repository job log [here](https://developer.mend.io/github/simonknittel/sinister-incorporated). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNy4xMDMuMSIsInVwZGF0ZWRJblZlciI6IjM3LjEwMy4xIiwidGFyZ2V0QnJhbmNoIjoiZGV2ZWxvcCJ9-->
](https://renovatebot.com){kind=link}
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
About the changes
Relates to roadmap item: Unleash/unleash#2255