Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

🟢 feat: Dependent feature toggles #2255

Closed
ivarconr opened this issue Oct 25, 2022 · 4 comments
Closed

🟢 feat: Dependent feature toggles #2255

ivarconr opened this issue Oct 25, 2022 · 4 comments
Assignees
@kwasniew
Labels
pinned

Comments

@ivarconr
Copy link
Member

ivarconr commented Oct 25, 2022 •
edited by kwasniew
Loading

Allow one toggle to depend on another toggle when evaluating if the toggle is enabled.
image (15)

Should be possible to depend on multiple toggles:
image (16)

We will not support multiple toggles in a chain
image (17)

We will not support circular dependencies
image (18)

Note
This will also require updates to ALL SDKs, so we should align on the protocol quite early.
@sullrich84
Copy link

sullrich84 commented Oct 31, 2022 •
edited
Loading

+1

Was going to suggest that too! Currently we map our toggle dependencies in the code to offer a single GLOBAL_TOGGLE for multiple SUB_TOGGLES.

@thomasheartman thomasheartman moved this from New to Todo in Issues and PRs Nov 1, 2022
@ArekCzarnik
Copy link

+1
It would be nice to have these features!

@ivarconr ivarconr moved this from Q4-2022 to Q1-2023 in Unleash Public Roadmap 🚀 Jan 19, 2023
@kwasniew
Copy link
Contributor

kwasniew commented Sep 19, 2023 •
edited
Loading

This issue is actively worked on starting this week. We'll be adding updates after major milestones.

@Tymek Tymek mentioned this issue Sep 26, 2023
Merged
@ivarconr ivarconr changed the title feat: Dependent feature toggles 🔥 feat: Dependent feature toggles Oct 2, 2023
@ivarconr ivarconr moved this from Q1-2023 to Q4-2023 in Unleash Public Roadmap 🚀 Oct 2, 2023
This was referenced Oct 6, 2023
Merged
Closed
thomasheartman added a commit to Unleash/unleash-types-rs that referenced this issue Oct 11, 2023
@thomasheartman
feat: add dependencies property to client feature struct
a23a807 
This change adds the `dependencies` property to the client feature
struct, opening the path for dependent feature toggles:

Unleash/unleash#2255
@thomasheartman thomasheartman mentioned this issue Oct 11, 2023
Merged
thomasheartman added a commit to Unleash/unleash-types-rs that referenced this issue Oct 12, 2023
@thomasheartman
feat: add dependencies property to client feature struct (#30)
573d86d 
## Description


This change adds the dependencies property to the client feature
struct, opening the path for dependent feature toggles:

Unleash/unleash#2255

## Commits

* feat: add `dependencies` property to client feature struct

This change adds the `dependencies` property to the client feature
struct, opening the path for dependent feature toggles:

Unleash/unleash#2255

* Add tests for dependent features
@kwasniew
Copy link
Contributor

kwasniew commented Dec 1, 2023 •
edited
Loading

This feature is implemented: https://docs.getunleash.io/reference/dependent-features with single parent dependencies for now

@kwasniew kwasniew closed this as completed Dec 1, 2023
@github-project-automation github-project-automation bot moved this from Todo to Done in Issues and PRs Dec 1, 2023
@ivarconr ivarconr changed the title 🔥 feat: Dependent feature toggles 🟢 feat: Dependent feature toggles Dec 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@kwasniew kwasniew

Labels
pinned
Projects
Unleash Public Roadmap 🚀
Status: Q4-2023
Milestone
No milestone
Development

No branches or pull requests
5 participants
@ivarconr @ArekCzarnik @sullrich84 @kwasniew @thomasheartman