Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add dependencies property to client feature struct #30

Merged
merged 2 commits into from
Oct 12, 2023
Merged

feat: add dependencies property to client feature struct #30

merged 2 commits into from
Oct 12, 2023

Conversation

thomasheartman
Copy link
Contributor

This change adds the dependencies property to the client feature
struct, opening the path for dependent feature toggles:

Unleash/unleash#2255

@thomasheartman
feat: add dependencies property to client feature struct
a23a807 
This change adds the `dependencies` property to the client feature
struct, opening the path for dependent feature toggles:

Unleash/unleash#2255
sighphyre
sighphyre requested changes Oct 11, 2023
View reviewed changes
Copy link
Member

@sighphyre sighphyre left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes look fine, we usually add a test to check that the new response shape is parsable and remains so. Later in the same file you can see some examples

@thomasheartman
Copy link
Contributor Author

Ah, perfect! Didn't catch that. I'll fix.

@thomasheartman
Copy link
Contributor Author

@sighphyre That should be what you're looking for. Test added in lib.rs and a new file with example data added.

sighphyre
sighphyre approved these changes Oct 11, 2023
View reviewed changes
Copy link
Member

@sighphyre sighphyre left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@thomasheartman thomasheartman merged commit 573d86d into main Oct 12, 2023
1 check passed
@thomasheartman thomasheartman deleted the feat/dependent-flag-types branch October 12, 2023 06:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sighphyre sighphyre sighphyre approved these changes

@kwasniew kwasniew kwasniew approved these changes

@chriswk chriswk Awaiting requested review from chriswk

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@thomasheartman @kwasniew @sighphyre