Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

BUG: Unfeaturing a library as an admin does not update in the resident view #592

Closed
calisio opened this issue Dec 17, 2024 · 3 comments · Fixed by #631
Closed

BUG: Unfeaturing a library as an admin does not update in the resident view #592

calisio opened this issue Dec 17, 2024 · 3 comments · Fixed by #631
Assignees
@carddev81
Labels
bug Something isn't working

Comments

@calisio
Copy link
Contributor

calisio commented Dec 17, 2024

Describe the bug
Unfeaturing a library does not update that featured library in the frontend of the resident. See example video below.

To Reproduce
Steps to reproduce the behavior:

  1. Go to Knowledge Center Management as an admin and feature a library that has not yet been featured (and make sure that it is visible).
  2. Go to student portal and check trending content page to see featured library.
  3. Go back to knowledge center management to unfeature that same library.
  4. Go back to student portal and see the featured library still exists.

Expected behavior
When unfeatured, the library should no longer appear in trending content.

Screenshots

Screen.Recording.2024-12-17.at.11.53.08.AM.mov

Desktop (please complete the following information):

  • OS: Version 15.1.1
  • Browser Chrome
  • Version 131.0.6778.140 (Official Build) (arm64)
@calisio calisio added the bug Something isn't working label Dec 17, 2024
@jtucholski
Copy link
Contributor

It is possible that this might've been fixed the week of 12/23. Please confirm that it still exists before working on the issue.

@CK-7vn
Copy link
Member

CK-7vn commented Jan 6, 2025

Ya, this is still a thing apparently. Dang.

@calisio
Copy link
Contributor Author

calisio commented Jan 6, 2025

It seems like unfeaturing updates correctly on the admin side- see video below.

Screen.Recording.2025-01-06.at.1.35.10.PM.mov

Not sure what the issue could be. Must be something in the backend because they call the same api endpoint.

@carddev81 carddev81 self-assigned this Jan 7, 2025
carddev81 added a commit to carddev81/UnlockEdv2 that referenced this issue Jan 7, 2025
@carddev81
fix: add featuring libraries to resident view when library is feature…
f2952cf 
…d per UnlockedLabs#592 and display featured content to other admins per UnlockedLabs#629
@carddev81 carddev81 mentioned this issue Jan 7, 2025
Merged
calisio pushed a commit that referenced this issue Jan 9, 2025
@carddev81
Fixes for hover-state icons, display of course titles, featuring func…
3771e8c 
…tionality, and favoriting per issues #592, #617, #612, #627, #629  (#631)

* fix: move course title before platform provider within Grid view and remove bullet point when no start/end date

* fix: add cursor-pointer CSS style onto interactive elements per #617

* fix: add featuring libraries to resident view when library is featured per #592 and display featured content to other admins per #629

* fix: modify query to allow resident to favorite featured libraries

* fix: modify query to allow resident to favorite featured libraries and modified libaries query to display featured libraries to other admins at the same facility
PThorpe92 pushed a commit that referenced this issue Jan 9, 2025
@carddev81 @PThorpe92
fix: hover-state icons, display of course titles, featuring/fav funct…
a40df16 
…ionality

* fix: move course title before platform provider within Grid view and remove bullet point when no start/end date

* fix: add cursor-pointer CSS style onto interactive elements per #617

* fix: add featuring libraries to resident view when library is featured per #592 and display featured content to other admins per #629

* fix: modify query to allow resident to favorite featured libraries

* fix: modify query to allow resident to favorite featured libraries and modified libaries query to display featured libraries to other admins at the same facility
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@carddev81 carddev81

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
4 participants
@jtucholski @calisio @CK-7vn @carddev81