-
Notifications
You must be signed in to change notification settings - Fork 843
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
improve: add Python 3.12 support #3033
improve: add Python 3.12 support #3033
Conversation
Thanks for this @nicoloboschi ! Just turned on the CI pipeline. If I recall correctly, it was |
CI failure was due to this. We may be able to work around that though. ERROR: Cannot install argilla==1.28.0 because these package versions have conflicting dependencies.
The conflict is caused by:
argilla 1.28.0 depends on numpy<1.24.0
The user requested (constraint) numpy>=1.26.0
ERROR: ResolutionImpossible: for help visit https://pip.pypa.io/en/latest/topics/dependency-resolution/#dealing-with-dependency-conflicts
To fix this you could try to:
1. loosen the range of package versions you've specified
2. remove package versions to allow pip attempt to solve the dependency conflict |
Ahh disregard, I see you have a PR open for 3.12 support in Argilla as well. |
@MthwRobinson hi I experience the below error with onnx when trying to use python 3.12 with unstructured I reckon its due to python support then. When can I expect this PR to be released? I really don't want to downgrade my entire app for this |
Meanwhile are there any hotfixes I can apply? |
@gokturkDev - In the meantime, I'd try manually running |
Hey thanks for the response. I ended up installing the latest onnx manually instead of using the one installed as an unstructured dependency and its working so far 👍 |
@nicoloboschi - Going to merge this into a feature branch and then get it into |
5d74bea
into
Unstructured-IO:2959/py32-support
New PR is #3047 |
### Summary Closes #2959. Updates the dependency and CI to add support for Python 3.12. The MongoDB ingest tests were disabled due to jobs like [this one](https://github.com/Unstructured-IO/unstructured/actions/runs/9133383127/job/25116767333) failing due to issues with the `bson` package. `bson` is a dependency for the AstraDB connector, but `pymongo` does not work when `bson` is installed from `pip`. This issue is documented by MongoDB [here](https://pymongo.readthedocs.io/en/stable/installation.html). Spun off #3049 to resolve this. Issue seems unrelated to Python 3.12, though unsure why this didn't surface previously. Disables the `argilla` tests because `argilla` does not yet support Python 3.12. We can add the `argilla` tests back in once the PR references below is merged. You can still use the `stage_for_argilla` function if you're on `python<3.12` and you install `argilla` yourself. - argilla-io/argilla#4837 --------- Co-authored-by: Nicolò Boschi <boschi1997@gmail.com>
Draft: currently blocked by argilla not supporting 3.12
Waiting for this PR to be released: argilla-io/argilla#4837
Fixes #2959