improve: add Python 3.12 support (#3033) #3047
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Draft: currently blocked by argilla not supporting 3.12 Waiting for this PR to be released: argilla-io/argilla#4837 Fixes #2959 --------- Co-authored-by: Matt Robinson <mrobinson@unstructured.io> Co-authored-by: Matt Robinson <mrobinson@unstructuredai.io>
…ctured into 2959/py32-support
|
Looks like there's a package version issue that needs to be run down for the GCS connector: Exception ignored in: <function AbstractBufferedFile.__del__ at 0x7fe177b8f3a0>
Traceback (most recent call last):
File "/home/runner/work/unstructured/unstructured/.venv/lib/python3.9/site-packages/fsspec/spec.py", line 1971, in __del__
self.close()
File "/home/runner/work/unstructured/unstructured/.venv/lib/python3.9/site-packages/fsspec/spec.py", line 1949, in close
self.flush(force=True)
File "/home/runner/work/unstructured/unstructured/.venv/lib/python3.9/site-packages/fsspec/spec.py", line 1808, in flush
self._initiate_upload()
File "/home/runner/work/unstructured/unstructured/.venv/lib/python3.9/site-packages/gcsfs/core.py", line 1509, in _initiate_upload
self.content_type,
AttributeError: 'GCSFile' object has no attribute 'content_type' |
MthwRobinson
commented
May 17, 2024
|
Looks like the Mongo failures are related to this. The Mongo client ships with its own version of |
…ctured into 2959/py32-support
|
Captured the issue related to |
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
github-merge-queue bot
pushed a commit
that referenced
this pull request
May 28, 2024
### Summary Closes #3049. Reenables the MongoDB connector test, which was disabled previously in #3047 due to incompatibility between the `pymongo` and the `bson` package from `pip`, which is a dependency for the Astra connector. Per the `pymongo` docs below, `pymongo` ships with its own version of `bson` and installing `bson` from `pip` breaks `pymongo`. - https://pymongo.readthedocs.io/en/stable/installation.html ### Testing Ingest tests ran successfully for the [source connector](https://github.com/Unstructured-IO/unstructured/actions/runs/9273154676/job/25512636315) and the [destination connector](https://github.com/Unstructured-IO/unstructured/actions/runs/9273154676/job/25512635546).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Closes #2959. Updates the dependency and CI to add support for Python 3.12.
The MongoDB ingest tests were disabled due to jobs like this one failing due to issues with the
bsonpackage.bsonis a dependency for the AstraDB connector, butpymongodoes not work whenbsonis installed frompip. This issue is documented by MongoDB here. Spun off #3049 to resolve this. Issue seems unrelated to Python 3.12, though unsure why this didn't surface previously.Disables the
argillatests becauseargilladoes not yet support Python 3.12. We can add theargillatests back in once the PR references below is merged. You can still use thestage_for_argillafunction if you're onpython<3.12and you installargillayourself.