Remove root numpy and process multiple run groups #177
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cbadams2
reviewed
Jul 14, 2023
|
Tested without root_numpy and files appeared to be generate correctly. |
|
So, big issues in the migration matrix: but this looks pretty easily solved by modifying the change to irfloader in dce1dcd because it looks like the array was transposed when it wasn't suppose to be. I've attempted this fix here: 7a77317 and this is how the energy bias looks now:
(please ignore my stupid error with n_bins_y in the declaration of a, I fix this is a minor commit. |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove the usage of root_numpy, which is outdated and no longer supported. Complying with #86 and #88.
Fix the loading of multiple run-groups in the runlist.
Minor edit to README including instructions for mamba installation alternative (#175).