Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update api_v2.py to match upstream #323

Merged
merged 2 commits into from
Sep 9, 2023
Merged

Update api_v2.py to match upstream #323

merged 2 commits into from
Sep 9, 2023

Conversation

hieplpvip
Copy link
Contributor

Description

Type of change: bug fix

What

Update api_v2.py to match upstream

Why

While diffing api_v2.py in our repo against DMOJ's, I found several differences although we never touched that file.

Some differences are due to missing DMOJ/online-judge@0c009fa, so I cherry-picked that.

The other difference (hidden_scoreboard) is from DMOJ/online-judge#1843, which is not merged because we implemented hidden scoreboard before DMOJ.

How Has This Been Tested?

Not tested

Checklist

  • I have explained the purpose of this PR.
  • I have performed a self-review of my own code

By submitting this pull request, I confirm that my contribution is made under the terms of the AGPL-3.0 License.

Copy link
Contributor

@leduythuccs leduythuccs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@leduythuccs leduythuccs merged commit faadb0b into master Sep 9, 2023
6 checks passed
@leduythuccs leduythuccs deleted the hiep/fix-api branch September 9, 2023 21:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants