Full hidden scoreboard & Post-window own scoreboard #1843
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #1843 +/- ##
==========================================
+ Coverage 46.09% 46.11% +0.02%
==========================================
Files 224 224
Lines 12876 12882 +6
==========================================
+ Hits 5935 5941 +6
Misses 6941 6941
Continue to review full report at Codecov.
|
This new scoreboard type allows a contest's scoreboard to be permanently hidden to the public.
To provide a better UX, especially for fully-hidden contests, contestants can now see their own participation after they have completed the contest.
Riolku
force-pushed
the
full-hidden-scoreboard
branch
from
70487cf to
ece53cd
Compare
Ninjaclasher
approved these changes
Feb 22, 2022
quantum5
approved these changes
Feb 22, 2022
Riolku
added a commit
to Riolku/online-judge
that referenced
this pull request
Feb 22, 2022
After DMOJ#1843, because of a misplaced bracket, users can't see submissions from contests with visible scoreboards.
Riolku
added a commit
to Riolku/online-judge
that referenced
this pull request
Feb 22, 2022
After DMOJ#1843, because of a misplaced bracket, users can't see submissions from contests with visible scoreboards.
kiritofeng
pushed a commit
that referenced
this pull request
Feb 22, 2022
After #1843, because of a misplaced bracket, users can't see submissions from contests with visible scoreboards.
Riolku
added a commit
to Riolku/online-judge
that referenced
this pull request
Feb 24, 2022
After DMOJ#1843, because of a misplaced bracket, users can't see submissions from contests with visible scoreboards.
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds support for a fully-hidden scoreboard type, i.e., one that is hidden even after the contest finishes.
In such a case, it is expected that it would be nice for users to be able to see their own participation, so the second commit allows users to see their own scoreboard if they have completed the contest.