DEFAULT_FILE_NAME_TEMPLATEの拡張子無し版を定義
#1483
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Hiroshiba
approved these changes
Aug 6, 2023
|
ありがとうございます。ちょうど構造が分かっているので、2点ほどe2eテストの方に追加した方が良さそうなもの(エラーハンドリングが正常に機能しているか)を書かせて貰いました！ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
内容
DEFAULT_FILE_NAME_TEMPLATEから
.wavを取り除いた定数を新たに定義します。さらに、PROJECT_NAMEと混ざらないようにAUDIOを名前に付け足します。
また、それによって処理を簡略化できる
src\components\FileNamePatternDialog.vueもリファクタリングします。ユーザー視点での変更はありません。
関連 Issue
ref #1475
上記の一環です。
スクリーンショット・動画など
その他