Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
以下のパターンも欲しいかな、と思いました、一応コメントまで…
|
|
なるほどです。遷移が不要なので本来はコンポーネント単位のテストのが適切そうですが、無いのでここに書いときますか！ |
Hiroshiba
commented
Aug 6, 2023
Comment on lines
-27
to
+28
| await page.getByText("ツールバーのカスタマイズ").click(); | ||
| await getQuasarMenu(page, "ツールバーのカスタマイズ").click(); |
There was a problem hiding this comment.
メニューの内容は結構同じ案内があって一意に定まりにくいので専用関数を作ってみました。
Comment on lines
-40
to
+41
| await page | ||
| .locator("#q-portal--dialog--6") | ||
| await getNewestQuasarDialog(page) |
There was a problem hiding this comment.
ダイアログは開いた順番？で最後のindexが変わるので頑健に
| } | ||
|
|
||
| /** | ||
| * quasarのメニューのlocaltorを取得する |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
内容
書き出しファイル名パターンのテストを追加します。
連番がパターンに含まれていないとボタンが押せないとか、保存したら内容が表示されるとかをテストしています。
関連 Issue
スクリーンショット・動画など
その他