セルの全選択 #1963
Merged
セルの全選択 #1963
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
src/type/preload.ts
Outdated
| @@ -172,6 +172,10 @@ export const defaultHotkeySettings: HotkeySettingType[] = [ | |||
| action: "選択解除", | |||
| combination: HotkeyCombination("Escape"), | |||
| }, | |||
| { | |||
| action: "セル全選択", | |||
| combination: HotkeyCombination(!isMac ? "Ctrl shift A" : "Meta A"), | |||
There was a problem hiding this comment.
Suggested change
| combination: HotkeyCombination(!isMac ? "Ctrl shift A" : "Meta A"), | |
| combination: HotkeyCombination(!isMac ? "Ctrl Shift A" : "Meta Shift A"), |
MacはCmd+Aになってそうです。
There was a problem hiding this comment.
shiftは入れ忘れていました
他のメニューバーにあっても良さそうな機能といっしょにメーニューバーに追加してきます。
src/components/Talk/TalkEditor.vue
Outdated
| registerHotkeyWithCleanup({ | ||
| editor: "talk", | ||
| enableInTextbox: false, | ||
| name: "セル全選択", |
There was a problem hiding this comment.
「全てのセルを選択」の方が丁寧かも？
長いのが気になるなら「全て選択」「全セルを選択」とかいい感じだと思います。
There was a problem hiding this comment.
既存のnameと口調を合わせようと今確認したところ、既存のものも口調に揺れがある気がするのでそこと同時に直してきます。
|
既存のを変更したならマイグレーション（src/backend/common/ConfigManager.ts）書かないとダメそうな気がします． |
|
defaultHotkeySettingsに含まれているものしか書き換えていないので自動でされるマイグレーションだけで大丈夫そうです |
|
されてなさそうです |
Hiroshiba
approved these changes
Apr 30, 2024
|
ちょっとctrl+Aをセル全選択にできないか挑戦してみようと思います！ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
内容
セルの全選択をショートカットでできるようにしました
関連 Issue
#1962
その他
issueではctrl+Aとなっていましたがテキストの全選択と被り、重複が許されないようだったので仮にctrl+shift+Aとしました