Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@sevenc-nanashi @ShimagayaSatoka もしよかったらレビューいただけると･･･！！ |
Hiroshiba
commented
Apr 30, 2024
Comment on lines
-367
to
+372
| label: "全セルを選択", | ||
| onClick: async () => { | ||
| if (!uiLocked.value) { | ||
| await store.dispatch("SET_SELECTED_AUDIO_KEYS", { | ||
| audioKeys: audioKeys.value, | ||
| }); | ||
| } | ||
| }, | ||
| disableWhenUiLocked: true, | ||
| }, | ||
| ...(isMultiSelectEnabled.value | ||
| ? [ | ||
| { | ||
| type: "button", | ||
| label: "すべて選択", |
There was a problem hiding this comment.
「全セルを選択」を「すべて選択」に統一しました。
ちょっとややこしくなったかもなのですが、どうでしょう･･･？
There was a problem hiding this comment.
「すべて」でたしかに良さそうです
何をと書かなくても、選択できるものは各エディタで一種類ずつしかないので
それとセルと呼ぶよりかえって混乱が少ない気もしました
Hiroshiba
commented
Apr 30, 2024
Comment on lines
-175
to
-185
| { | ||
| action: "全セルを選択", | ||
| combination: HotkeyCombination(!isMac ? "Ctrl Shift A" : "Meta Shift A"), | ||
| }, |
There was a problem hiding this comment.
まだリリース前なのでマイグレーションコードは書かずに削除しています
|
問題ないと思うのでマージします！ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
内容
こちらのissueの内容です。
こちらの続きです
関連 Issue
close #1962
その他
ついでに複数選択がONのときだけ実行できるようにしておきました。（忘れてた）