ソング：MIDI読み込みを改善 #1982
Merged
ソング：MIDI読み込みを改善 #1982
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
sevenc-nanashi
force-pushed
the
add/lyric-midi
branch
from
4ee9f95 to
e15afe5
Compare
Hiroshiba
reviewed
May 3, 2024
| @@ -0,0 +1,166 @@ | |||
| import { | |||
There was a problem hiding this comment.
IMPORT_MIDI_FILEの大半をこっちのファイルに移動しちゃっても良い気がしますね！
だいぶ見やすくなりそうだし。こっちはindex.tsにして、import.tsを作るとかで。
まあもしよかったら別のプルリクエストでリファクタリングお願いできるとめちゃくちゃ助かります！
There was a problem hiding this comment.
(base: UInt8Array) => AbstractScore に抽象化するのを考えています。
Co-authored-by: Hiroshiba <hihokaruta@gmail.com>
|
レビューを反映しました。 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
内容
関連 Issue
スクリーンショット・動画など
（なし）
その他
synthv.midを作るのに使ったプロジェクト：synthv.svp.zip
とりあえずMIDIのメタイベントの歌詞に対応しました。XFフォーマットはパーサー書くのがしんどかったのと少なくともSynthVのMIDIは読み込めたのでパスしています。