Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ソング:MIDI読み込みを改善 #1982
ソング:MIDI読み込みを改善 #1982
Changes from all commits
fff788a
e28716b
6f376e5
cadfd79
0c52062
74d0140
eaf8155
a11d18b
fcbdc9d
e15afe5
4a7d819
19c9249
db5fb4d
4b6c3de
f4f5755
cc80548
b30f955
3b1c5a6
f39455b
352c768
4d7eb94
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
IMPORT_MIDI_FILE
の大半をこっちのファイルに移動しちゃっても良い気がしますね!だいぶ見やすくなりそうだし。こっちはindex.tsにして、import.tsを作るとかで。
まあもしよかったら別のプルリクエストでリファクタリングお願いできるとめちゃくちゃ助かります!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
(base: UInt8Array) => AbstractScore
に抽象化するのを考えています。