Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

変更:歌詞の入力内容チェックの正規表現を修正 #2293

Merged
merged 4 commits into from
Nov 25, 2024

Conversation

rokujyushi
Copy link
Contributor

内容

エンジンの mora_mapping.py 修正に合わせて
src/sing/domain.tsmoraPattern の正規表現を修正

スクリーンショット・動画など

image

その他

関連するエンジンのPR
VOICEVOX/voicevox_engine#1473

@rokujyushi rokujyushi requested a review from a team as a code owner October 12, 2024 13:05
@rokujyushi rokujyushi requested review from Hiroshiba and removed request for a team October 12, 2024 13:05
@voicevox-preview-pages
Copy link

🚀 プレビュー用ページを作成しました 🚀

更新時点でのコミットハッシュ:cdc539a

@rokujyushi
Copy link
Contributor Author

レビューお願いします。
内容はエンジンのテストと同じ正規表現です。

@Hiroshiba
Copy link
Member

ちょっとこちらでコンフリクト解消させていただきます!
(場所が移動されました)

Copy link
Member

@Hiroshiba Hiroshiba left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!!

新しい音が出てきて嬉しいです!!

@Hiroshiba Hiroshiba merged commit 7030529 into VOICEVOX:main Nov 25, 2024
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants