mora_mapping.py にOpenJTalkに無いKanaを追加
#1473
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Hiroshiba
reviewed
Oct 13, 2024
Comment on lines
375
to
378
| {"クィ", "kw", "i"}, | ||
| {"クゥ", "kw", "u"}, | ||
| {"クェ", "kw", "e"}, | ||
| {"クォ", "kw", "o"}, |
There was a problem hiding this comment.
ここ、{}ではなく()ですね！！！
ちなみに静的解析のpysen run format lintとかが便利かもです 🙏
|
あ！ Draftになってますが、実はもうレビュー可能だったりしますか？ 👀 |
|
レビューお願いします。 |
|
UserDict周りのテストが落ちていました。 以下の部分のコードを修正する必要がありそうです。（もし分からなかったら聞いてください！） |
|
タイトルがWIPのままになってるので変更させていただきます！ 🙏 |
Hiroshiba
changed the title
mora_mapping.py にOpenJTalkに無いKanaを追加mora_mapping.py にOpenJTalkに無いKanaを追加
Hiroshiba
reviewed
Nov 13, 2024
Hiroshiba
reviewed
Nov 13, 2024
|
mora_mapping.pyの修正については私のほうでも問題ないです。 |
|
おっとテスト落ちてますね、ちょっとこちらで変更してみます！ |
|
マージします！！ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
内容
mora_mapping.pyにOpenJTalkに無い以下のKanaを追加"キィ","ギィ","クァ","クィ","クゥ","クェ","クォ","グァ","グィ","グゥ","グェ","グォ",
"ヂェ","ヂャ","ヂュ","ヂョ","テェ","ニィ","ヒィ","ビィ","ピィ","ミィ","リィ","ウゥ"
関連 Issue
close #1463
その他
関連PR
変更：歌詞の入力内容チェックの正規表現を修正 voicevox#2293
以下のテストでエラー
デバッグ実行で動作確認
追加したKanaの一部の組み合わせで
mora_kana_to_mora_phonemesの中身がおかしくなる"クィ","クゥ","クェ","クォ"などで辞書に一致するキーがなくエラーになり合成に失敗する
2回目のデバッグ実行で再発
_mora_list_minimum変数の記述内容見直しテスト用プロジェクト.zip