Denoのstd/pathに置き換える #2365
Merged
Denoのstd/pathに置き換える #2365
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sevenc-nanashi
requested review from
Hiroshiba
and removed request for
a team
Hiroshiba
reviewed
Nov 18, 2024
|
🚀 プレビュー用ページを作成しました 🚀 更新時点でのコミットハッシュ： |
|
多分prefer-node-protocolだけもできると思います |
|
１個１個導入するか考えるの大変なので、まとめてドサッと入れちゃいたい気持ちがあります･･･！ |
|
あ、それでも入れたいという感じでしたらまたコメントください。 |
|
（ちなみにテストが落ちていそうです 🙏 ） |
Hiroshiba
approved these changes
Nov 19, 2024
| import { isWindows } from "./platform"; | ||
|
|
||
| // OSにあったパス操作関数をエクスポートする。 | ||
| // NOTE: @std/pathのWindows判定は差し替えられないので、ここで判定する |
There was a problem hiding this comment.
（ただのコメントです）
なんとなくですが、今のコードとdenoのpathは完全互換ではないけど、大多数のブラウザやelectron環境で正しく動きそうな気はちょっとしてます。
えいやで変えてしまっても良いのかも？
（あるいは実は動かない環境がすでにあったり…？だとしたらこのコードは必須そう！）
There was a problem hiding this comment.
Copilot reviewed 7 out of 22 changed files in this pull request and generated no suggestions.
Files not reviewed (15)
- package.json: Language not supported
- src/components/Sing/ToolBar/EditTargetSwicher.vue: Evaluated as low risk
- src/components/Talk/TalkEditor.vue: Evaluated as low risk
- src/components/Talk/AudioDetail.vue: Evaluated as low risk
- src/components/Dialog/SettingDialog/SettingDialog.vue: Evaluated as low risk
- src/store/project.ts: Evaluated as low risk
- src/backend/browser/fileImpl.ts: Evaluated as low risk
- src/type/preload.ts: Evaluated as low risk
- src/sing/viewHelper.ts: Evaluated as low risk
- .eslintrc.js: Evaluated as low risk
- src/store/singing.ts: Evaluated as low risk
- src/backend/electron/main.ts: Evaluated as low risk
- src/store/utility.ts: Evaluated as low risk
- tests/unit/composable/useModifierKey.spec.ts: Evaluated as low risk
- tests/unit/domain/project.spec.ts: Evaluated as low risk
|
マージします！ |
tsukumijima
added a commit
to Aivis-Project/AivisSpeech
that referenced
this pull request
Dec 3, 2024
upstream 側の修正漏れだったようで困る… ref: VOICEVOX/voicevox#2365
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
内容
Denoのstd/pathはブラウザでも動くのでそれを使うようにします。
これによりvite-plugin-note-polyfillsを消せます。
関連 Issue
（なし）
スクリーンショット・動画など
（なし）
その他
prefer-node-protocolをしたい気持ちがあります。