Refactoring: ホットキー周りの初期値などをdomainに切り出す #2366
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Hiroshiba
force-pushed
the
リファクタリング、ホットキー周りの初期値などをdomainに切り出す
branch
from
53f154f to
4233089
Compare
|
🚀 プレビュー用ページを作成しました 🚀 更新時点でのコミットハッシュ： |
There was a problem hiding this comment.
Copilot reviewed 5 out of 13 changed files in this pull request and generated no comments.
Files not reviewed (8)
- src/components/Menu/MenuItem.vue: Evaluated as low risk
- src/components/Talk/TalkEditor.vue: Evaluated as low risk
- src/components/Dialog/HotkeyRecordingDialog.vue: Evaluated as low risk
- src/components/Dialog/HotkeySettingDialog.vue: Evaluated as low risk
- src/domain/hotkeyAction.ts: Evaluated as low risk
- src/backend/common/ConfigManager.ts: Evaluated as low risk
- src/backend/browser/sandbox.ts: Evaluated as low risk
- src/store/setting.ts: Evaluated as low risk
|
ChatGPTのo1君にもレビューしてもらいました レビューで指摘されてますが、一部のショートカットキーが型に存在してるのにデフォルトショートカットキー一覧にないやつがありそうでした！ 問題ないと思うのでマージします！ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
内容
タイトルの通り、ショートカットキー周りのコードをpreload.tsからdomainに移します。
preload.tsダイエットの一貫。
isMacがpreload.ts側に定義されていて相互参照になってしまいそうです。
これは
に含まれる、isMacなどをhelperに移すリファクタリングで解決するはず。
その他
でisMacをDI可能にしようとしたとき、結構複雑だったのでとりあえず切り出しだけやってしまおうと思いました。