-
Notifications
You must be signed in to change notification settings - Fork 204
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ユーザー辞書機能:単語の更新/削除機能を追加 #338
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
良さそうだと思いました!
一点だけ、テストに関して気になったので、コメントしておきます。
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTMです!
これでエディタ側の実装にフェーズに移行できそうですね...!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
きれいに感じました!!
RESTっぽくするためにも、/id
のとこだけ変更して頂けると・・・!
valid_dict_dict = { | ||
"next_id": 1, | ||
"words": { | ||
"0": { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
IDはintなんでしたっけ、stringなんでしたっけ
) | ||
|
||
valid_dict_dict = { | ||
"next_id": 1, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
将来辞書エディターみたないなのが出たりしたとき、next_id
の数値と、word idがずれてしまう未来が見えました。
uuidにしても良いかも?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!!!
初学者の方がPUTやDELETEの使い方をわからない可能性があるかもなので、READMEにcurlでの例があるとちょっとやさしいのかなと思いました。
(あっても間違っちゃうかもですが)
内容
題の通り
関連 Issue
その他
#334 (comment)
こちらの変更も一緒に行っています。
また、重複している処理があったので削除しています。(jsonへ2回書き込んでいた)