Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ユーザー辞書のIDをUUIDに変更 #340

Merged
merged 3 commits into from
Feb 26, 2022

Conversation

takana-v
Copy link
Member

内容

今までユーザ辞書ではID(数字)で管理を行っていましたがUUIDに変更します。
これに伴いjsonファイルのフォーマットに破壊的変更が入ります。

#338 (comment)

関連Issue

APIに変更が入っているのでエディタ側にも変更が必要そうです。
ご確認お願いします。 @y-chan

その他

バージョンを跨ぐとマイグレーションを行う必要が出てきてめんどくさいので0.11のリリースよりも前にマージしたいです。

@takana-v takana-v requested review from Hiroshiba and y-chan February 26, 2022 15:14
@github-actions
Copy link

github-actions bot commented Feb 26, 2022

Coverage Result

Resultを開く
Name Stmts Miss Cover
voicevox_engine/init.py 1 0 coverage-100%
voicevox_engine/acoustic_feature_extractor.py 75 0 coverage-100%
voicevox_engine/dev/synthesis_engine/init.py 2 0 coverage-100%
voicevox_engine/dev/synthesis_engine/mock.py 36 2 coverage-94%
voicevox_engine/full_context_label.py 162 3 coverage-98%
voicevox_engine/kana_parser.py 86 1 coverage-99%
voicevox_engine/model.py 122 7 coverage-94%
voicevox_engine/mora_list.py 4 0 coverage-100%
voicevox_engine/preset/Preset.py 12 0 coverage-100%
voicevox_engine/preset/PresetLoader.py 34 1 coverage-97%
voicevox_engine/preset/init.py 3 0 coverage-100%
voicevox_engine/synthesis_engine/init.py 5 0 coverage-100%
voicevox_engine/synthesis_engine/core_wrapper.py 156 126 coverage-19%
voicevox_engine/synthesis_engine/make_synthesis_engines.py 51 42 coverage-18%
voicevox_engine/synthesis_engine/synthesis_engine.py 108 2 coverage-98%
voicevox_engine/synthesis_engine/synthesis_engine_base.py 62 7 coverage-89%
voicevox_engine/user_dict.py 76 8 coverage-89%
voicevox_engine/utility/init.py 3 0 coverage-100%
voicevox_engine/utility/connect_base64_waves.py 35 3 coverage-91%
voicevox_engine/utility/engine_root.py 9 2 coverage-78%
TOTAL 1042 204 coverage-80%

voicevox_engine/user_dict.py Outdated Show resolved Hide resolved
@Hiroshiba
Copy link
Member

良さそうです!!一箇所だけ気になったのでコメントしてみました!

Copy link
Member

@y-chan y-chan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTMです!
next idの概念がなくなり、よりすっきりしたと思います...!

Copy link
Member

@Hiroshiba Hiroshiba left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!!!

@Hiroshiba Hiroshiba merged commit a7f3a97 into VOICEVOX:master Feb 26, 2022
@takana-v takana-v deleted the dict-id-to-uuid branch February 26, 2022 18:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants