-
Notifications
You must be signed in to change notification settings - Fork 204
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ユーザー辞書のIDをUUIDに変更 #340
Merged
Merged
ユーザー辞書のIDをUUIDに変更 #340
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Hiroshiba
requested changes
Feb 26, 2022
良さそうです!!一箇所だけ気になったのでコメントしてみました! |
y-chan
approved these changes
Feb 26, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTMです!
next idの概念がなくなり、よりすっきりしたと思います...!
Hiroshiba
approved these changes
Feb 26, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!!!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
内容
今までユーザ辞書ではID(数字)で管理を行っていましたがUUIDに変更します。
これに伴いjsonファイルのフォーマットに破壊的変更が入ります。
#338 (comment)
関連Issue
APIに変更が入っているのでエディタ側にも変更が必要そうです。
ご確認お願いします。 @y-chan
その他
バージョンを跨ぐとマイグレーションを行う必要が出てきてめんどくさいので0.11のリリースよりも前にマージしたいです。