Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

エンジンのマニフェストを追加 #387

Merged
merged 3 commits into from
May 9, 2022

Conversation

takana-v
Copy link
Member

@takana-v takana-v commented Apr 14, 2022

内容

SynthesisEngineに情報を持たせることも検討しましたが、run.pyに持たせるようにしました。
base_info.jsonにversion、name、サンプリングレートを書いておき、残りの項目を各ファイルで上書きするようにしました。
(version.txt、name.txtと別々にするとファイル数多くなると思ったのでこのようにしました。)

関連 Issue

その他

とりあえずマージまで必要な作業を羅列しておきます。

  • マニフェストの様式を正式に決定
  • VVRにマニフェストのリソースを追加
  • ビルド周り修正

@github-actions
Copy link

github-actions bot commented Apr 14, 2022

Coverage Result

Resultを開く
Name Stmts Miss Cover
voicevox_engine/init.py 1 0 coverage-100%
voicevox_engine/acoustic_feature_extractor.py 75 0 coverage-100%
voicevox_engine/dev/synthesis_engine/init.py 2 0 coverage-100%
voicevox_engine/dev/synthesis_engine/mock.py 40 4 coverage-90%
voicevox_engine/experimental/init.py 0 0 coverage-100%
voicevox_engine/experimental/guided_extractor.py 128 94 coverage-27%
voicevox_engine/experimental/julius4seg/init.py 0 0 coverage-100%
voicevox_engine/experimental/julius4seg/converter.py 298 295 coverage-1%
voicevox_engine/experimental/julius4seg/sp_inserter.py 116 89 coverage-23%
voicevox_engine/full_context_label.py 162 3 coverage-98%
voicevox_engine/kana_parser.py 86 1 coverage-99%
voicevox_engine/model.py 146 7 coverage-95%
voicevox_engine/mora_list.py 4 0 coverage-100%
voicevox_engine/part_of_speech_data.py 5 0 coverage-100%
voicevox_engine/preset/Preset.py 12 0 coverage-100%
voicevox_engine/preset/PresetLoader.py 34 1 coverage-97%
voicevox_engine/preset/init.py 3 0 coverage-100%
voicevox_engine/synthesis_engine/init.py 5 0 coverage-100%
voicevox_engine/synthesis_engine/core_wrapper.py 182 145 coverage-20%
voicevox_engine/synthesis_engine/make_synthesis_engines.py 52 43 coverage-17%
voicevox_engine/synthesis_engine/synthesis_engine.py 181 69 coverage-62%
voicevox_engine/synthesis_engine/synthesis_engine_base.py 68 9 coverage-87%
voicevox_engine/user_dict.py 98 10 coverage-90%
voicevox_engine/utility/init.py 3 0 coverage-100%
voicevox_engine/utility/connect_base64_waves.py 35 3 coverage-91%
voicevox_engine/utility/engine_root.py 9 2 coverage-78%
TOTAL 1745 775 coverage-56%

@takana-v takana-v marked this pull request as ready for review April 26, 2022 14:03
@Hiroshiba
Copy link
Member

マニフェストの様式を正式に決定
VVRにマニフェストのリソースを追加

こちら、とりあえずなくてもマージ可能なので、先にマージしてしまって並行して進めても良いのかなと思いました!

Copy link
Member

@Hiroshiba Hiroshiba left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ほぼLGTMです・・・!!

manifest_assets/base_info.json Outdated Show resolved Hide resolved
@@ -25,6 +25,8 @@

from voicevox_engine import __version__
from voicevox_engine.cancellable_engine import CancellableEngine
from voicevox_engine.engine_manifest import EngineManifestLoader
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

他のクラスはついてないので、短くするためにEngineなくても良いかも?(あまり強い意見じゃないです)

@Hiroshiba
Copy link
Member

マージします!!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants