Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

マニフェストのコンストラクトを修正 #404

Merged
merged 2 commits into from
May 14, 2022
Merged

マニフェストのコンストラクトを修正 #404

merged 2 commits into from
May 14, 2022

Conversation

Hiroshiba
Copy link
Member

内容

マニフェスト用の情報に関して、base_info.jsonとファイルの2箇所にデータを記入する箇所があります。
どちらを優先すれば良いのかが混乱しそうだったので、base_info.json側のデータを消去してみました。

関連 Issue

その他

@Hiroshiba Hiroshiba requested a review from takana-v May 14, 2022 10:42
@github-actions
Copy link

github-actions bot commented May 14, 2022

Coverage Result

Resultを開く
Name Stmts Miss Cover
voicevox_engine/init.py 1 0 coverage-100%
voicevox_engine/acoustic_feature_extractor.py 75 0 coverage-100%
voicevox_engine/dev/synthesis_engine/init.py 2 0 coverage-100%
voicevox_engine/dev/synthesis_engine/mock.py 40 4 coverage-90%
voicevox_engine/experimental/init.py 0 0 coverage-100%
voicevox_engine/experimental/guided_extractor.py 128 94 coverage-27%
voicevox_engine/experimental/julius4seg/init.py 0 0 coverage-100%
voicevox_engine/experimental/julius4seg/converter.py 298 295 coverage-1%
voicevox_engine/experimental/julius4seg/sp_inserter.py 116 89 coverage-23%
voicevox_engine/full_context_label.py 162 3 coverage-98%
voicevox_engine/kana_parser.py 86 1 coverage-99%
voicevox_engine/model.py 147 7 coverage-95%
voicevox_engine/mora_list.py 4 0 coverage-100%
voicevox_engine/part_of_speech_data.py 5 0 coverage-100%
voicevox_engine/preset/Preset.py 12 0 coverage-100%
voicevox_engine/preset/PresetLoader.py 34 1 coverage-97%
voicevox_engine/preset/init.py 3 0 coverage-100%
voicevox_engine/synthesis_engine/init.py 5 0 coverage-100%
voicevox_engine/synthesis_engine/core_wrapper.py 182 145 coverage-20%
voicevox_engine/synthesis_engine/make_synthesis_engines.py 52 43 coverage-17%
voicevox_engine/synthesis_engine/synthesis_engine.py 181 69 coverage-62%
voicevox_engine/synthesis_engine/synthesis_engine_base.py 68 9 coverage-87%
voicevox_engine/user_dict.py 107 10 coverage-91%
voicevox_engine/utility/init.py 3 0 coverage-100%
voicevox_engine/utility/connect_base64_waves.py 35 3 coverage-91%
voicevox_engine/utility/engine_root.py 9 2 coverage-78%
TOTAL 1755 775 coverage-56%

Copy link
Member

@takana-v takana-v left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!
分かりやすくなったと思います。

後から代入しなくなったので、configのvalidate_assignmentが不要になりました。
そこの部分を修正しておきました。
(githubからsuggestionを作成できなかったので直接コミットしています)

@Hiroshiba Hiroshiba merged commit cf1c95e into VOICEVOX:master May 14, 2022
@Hiroshiba Hiroshiba deleted the マニフェストのコンストラクトを修正 branch May 14, 2022 10:51
@Hiroshiba
Copy link
Member Author

レビュー&改善ありがとうございます!!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants