Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

This extension breaks the Add Next Occurrence command and shortcut #1311

Closed
RodrigoRoaRodriguez opened this issue Feb 18, 2017 · 3 comments · Fixed by #1631
Closed

This extension breaks the Add Next Occurrence command and shortcut #1311

RodrigoRoaRodriguez opened this issue Feb 18, 2017 · 3 comments · Fixed by #1631
Labels

Comments

@RodrigoRoaRodriguez
Copy link

RodrigoRoaRodriguez commented Feb 18, 2017

  • Click thumbs-up 👍 on this issue if you want it!
  • Click confused 😕 on this issue if not having it makes VSCodeVim unusable.

The VSCodeVim team prioritizes issues based on reaction count.


Add Next Occurrence shortcut is being hijacked by this extension.

What did you do? (Version 1)

test test
In insert mode selected test with the mouse, then pressed cmd-d and finally backspace.

What did you do? (Version 2)

|test test
In insert placed cursor at start (represented here as a pipe), then pressed cmd-d twice and finally backspace.

What did you expect to happen?

| |
Two cursors (represented here as pipes)

What happened instead?

| test
With this extension enabledcmd-d does nothing in insert mode.

This extension breaks the Add Next Occurrence command

~~What did you do? ~~

test test
In insert mode selected test with the mouse, select Add Next Occurrence in the menu bar and then press backspace.

What did you expect to happen?

| |
Two cursors (represented here as pipes)

What happened instead?

| test|
With this extension enabled Add Next Occurrence adds a second bugged cursor to the right that does not behave like the first one (inconsistent behavior between attempts in spite of same sequence of keypresses).

Technical details:

  • VSCode Version: 1.9.1
  • VsCodeVim Version: 0.5.3
  • OS: MacOS 10.12

Needless to say, all of the above work properly and consistently with the extension disabled.

@RodrigoRoaRodriguez RodrigoRoaRodriguez changed the title Bug: This extension breaks the Add Next Occurrence command and shortcut This extension breaks the Add Next Occurrence command and shortcut Feb 22, 2017
@RodrigoRoaRodriguez
Copy link
Author

Update:
For

  • VSCode Version: 1.10
  • VsCodeVim Version: 0.6.13

The second issue described(the Add Next Occurrence command) has been fixed but the first one (the shortcut being ignored) still applies.

@RodrigoRoaRodriguez
Copy link
Author

Update:

  • VSCode Version: 1.11.2
  • VsCodeVim Version: 0.6.18

This issue still applies for insert mode but does no longer seem to apply for normal mode.

@wildeyes
Copy link

wildeyes commented Apr 25, 2017

Ctrl-d only works in visual mode for me

johnfn added a commit that referenced this issue May 9, 2017
Fixes #1535, #1467, #1311: D-d doesn't work in insert mode
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants