Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes #1535, #1467, #1311: D-d doesn't work in insert mode #1631

Merged
merged 1 commit into from
May 9, 2017

Conversation

Chillee
Copy link
Member

@Chillee Chillee commented May 3, 2017

It's not really idiomatic, but I don't really see a way around it.

One thing I'd like to add before we merge is a rebinding of C-d to D-d.

Also fixes #1467 and fixes #1311.

@Chillee Chillee changed the title Fixes #1360: D-d doesn't work in insert mode Fixes #1535: D-d doesn't work in insert mode May 3, 2017
@johnfn
Copy link
Member

johnfn commented May 3, 2017

Agreed on C-d - is there any reason we can't just make C-d another element in keys along with D-d?

@Chillee
Copy link
Member Author

Chillee commented May 3, 2017

C-d is already used for another motion. I was thinking we need to treat this somewhat similar to copy.

@johnfn
Copy link
Member

johnfn commented May 4, 2017

Right, and a pretty popular one too. Your idea makes sense.

@xconverge
Copy link
Member

So is this a WIP for that last rebinding?

@Chillee
Copy link
Member Author

Chillee commented May 7, 2017

@xconverge It turns out I never pushed my last fix. Considering the recent refactoring, I just redid it.

This should be good to go.

@Chillee Chillee changed the title Fixes #1535: D-d doesn't work in insert mode Fixes #1535, #1467, #1311: D-d doesn't work in insert mode May 7, 2017
@johnfn johnfn merged commit b05ba91 into VSCodeVim:master May 9, 2017
@johnfn
Copy link
Member

johnfn commented May 9, 2017

This is great but it's unfortunate we can't get that behavior and useCtrlKeys. We need some way to do a more refined type of mapping...

@Chillee
Copy link
Member Author

Chillee commented May 9, 2017

@johnfn We actually have a decent amount of issues related to keybindings. I don't use them that much, so I'm finding the motivation to handle them a bit ... lacking.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants