Fix c on line beginning#1302 #1303
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…nding at the beginning of a line
johnfn
reviewed
Feb 15, 2017
| @@ -2080,13 +2080,16 @@ export class ChangeOperator extends BaseOperator { | |||
|
|
|||
| public async run(vimState: VimState, start: Position, end: Position): Promise<VimState> { | |||
| const isEndOfLine = end.character === end.getLineEnd().character; | |||
| const isBeginning = | |||
There was a problem hiding this comment.
Position has a function called isLineBeginning() - could you use that one?
|
Sorry i got excited :) |
|
just wait... i need to make sure the tests pass again |
|
Cool, thanks for the PR! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changed the c Action to encounter for cases where the selection ends at the beginning of a line.
The tests revealed, that s is implemented using c(0,0).
Therefore i check, if this is a real selection before calling the getLeftThroughLineBreaks() function