Fix c on line beginning#1302

src/actions/actions.ts

@@ -2084,13 +2084,16 @@ export class ChangeOperator extends BaseOperator {
 
     public async run(vimState: VimState, start: Position, end: Position): Promise<VimState> {
         const isEndOfLine = end.character === end.getLineEnd().character;
+        const isBeginning =
+                end.isLineBeginning() &&
+                !start.isLineBeginning(); // to ensure this is a selection and not e.g. and s command
         let state = vimState;
 
         // If we delete to EOL, the block cursor would end on the final character,
         // which means the insert cursor would be one to the left of the end of
         // the line. We do want to run delete if it is a multiline change though ex. c}
         if (Position.getLineLength(TextEditor.getLineAt(start).lineNumber) !== 0 || (end.line !== start.line)) {
-          if (isEndOfLine) {
+          if (isEndOfLine || isBeginning) {
             state = await new DeleteOperator(this.multicursorIndex).run(vimState, start, end.getLeftThroughLineBreaks());
           } else {
             state = await new DeleteOperator(this.multicursorIndex).run(vimState, start, end);

test/mode/modeVisual.test.ts

@@ -640,6 +640,14 @@ suite("Mode Visual", () => {
     endMode: ModeName.Normal
   });
 
+  newTest({
+    title: "Changes on a firstline selection will not delete first character",
+    start: ["test|jojo", "haha"],
+    keysPressed: "vj0c",
+    end: ["test|haha"],
+    endMode: ModeName.Insert
+  });
+
   suite("D command will remove all selected lines", () => {
     newTest({
       title: "D deletes all selected lines",
@@ -656,6 +664,5 @@ suite("Mode Visual", () => {
       end: ["first line", "|second line"],
       endMode: ModeName.Normal
     });
-
   });
 });