Corrected handling of Insert key to toggle insert mode #2295
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jpoon
requested changes
Jan 17, 2018
package.json
Outdated
| "keywords": [ | ||
| "vim", | ||
| "vi", | ||
| "vscodevim" |
There was a problem hiding this comment.
Can you make the minimal change necessary in this file?
| @@ -653,7 +653,7 @@ class CommandMoveHalfPageUp extends CommandEditorScroll { | |||
| @RegisterAction | |||
| export class CommandInsertAtCursor extends BaseCommand { | |||
| modes = [ModeName.Normal]; | |||
| keys = ['i']; | |||
| keys = [['i'], ['<insert>']]; | |||
There was a problem hiding this comment.
Oh cool. I don't know why I was surprised at first that the key maps to <insert>.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it: It addresses partially #1787 by including the Insert key in the keys for the CommandInsertAtCursor action, and creating a corresponding extension.vim_insert command to permit the extension to handle the key.
Which issue(s) this PR fixes: partially #1787